I've twice in a few days missed that something was accepted, but had inline comments. The comments are in the email but down in the middle of generally not-so-useful information.
Description
Description
Revisions and Commits
Revisions and Commits
| Status | Assigned | Task | ||
|---|---|---|---|---|
| Resolved | chad | T6962 Make inline comments part of main comment area in emails | ||
| Wontfix | chad | T6600 Design an HTML mail template |
Event Timeline
Comment Actions
We could also try something like:
$ arc land Revision D123 has new inline comments since your last update. Land anyway? [y/N]
This might make more sense after T1460, although I'm really hesitant about making that workflow heavy/blocking/mandatory.
Comment Actions
Another option which has come up in the past (but I think only on IRC) is giving reviewers an "Accept Next Update" action, which would accept as soon as the author updated, for use with "I have some minor inlines, but they should probably get fixed". You could just update with the same changeset if you didn't want to address them.
Comment Actions
I just assume the comment in email should look like the comment on the website. It's not as possible in text form, but html email should be better called out.
Comment Actions
D11402 re-jiggers the email such that its comment -> inline comments -> the rest of the stuff.
I guess this task can be about making the HTML version really hotttttt?