Differential - re-jigger mail such that inline comments show up right after the main comments.
ClosedPublic
Actions

Authored by btrahan on Jan 15 2015, 1:21 AM.

Details

Reviewers

epriestley
chad

Maniphest Tasks

T6962: Make inline comments part of main comment area in emails

Commits

Restricted Diffusion Commit
rP57761ce2202a: Differential - re-jigger mail such that inline comments show up right after…

Summary

Ref T6962. Mainly accomplished by re-factoring the base editor buildMailBody function and then using it differently in the DifferentialTransactionEditor.

Test Plan

commented on a revision leaving inline feedback. inspected via bin/mail and it looked good! also made a maniphest comment and checked that email, which still looked good.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 27383.Jan 15 2015, 1:21 AM

btrahan added a task: T6962: Make inline comments part of main comment area in emails.

btrahan retitled this revision from to Differential - re-jigger mail such that inline comments show up right after the main comments..

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added reviewers: epriestley, chad.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptJan 15 2015, 1:21 AM

epriestley accepted this revision.Jan 15 2015, 1:22 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jan 15 2015, 1:22 AM

e.g.

TEXT BODY
btrahan-oauth added a subscriber: btrahan-oauth.
btrahan-oauth added a comment.

yeah dude


INLINE COMMENTS
  FARTY:8 poop
  FARTY:12 stains
  FARTY:16 abound

REPOSITORY
  rFR First Repo

REVISION DETAIL
  http://phalanx.dev/D11

EMAIL PREFERENCES
  http://phalanx.dev/settings/panel/emailpreferences/

To: btrahan
Cc: btrahan-oauth

Closed by commit rP57761ce2202a: Differential - re-jigger mail such that inline comments show up right after… (authored by btrahan, committed by btrahan). · Explain WhyJan 15 2015, 1:23 AM

This revision was automatically updated to reflect the committed changes.

btrahan mentioned this in T6962: Make inline comments part of main comment area in emails.Jan 15 2015, 1:24 AM