Page MenuHomePhabricator

Auditing a commit before Phabricator Import failed to notify the commiter
Closed, ResolvedPublic

Assigned To
Authored By
foresightyj
Dec 25 2014, 8:49 AM
Referenced Files
F256471: 2.png
Dec 25 2014, 8:49 AM
F256469: 1.png
Dec 25 2014, 8:49 AM

Description

I had a hard time describing the issue in the title.

I imported a SVN repo to Phabricator (on Dec 22, 2014). If I browse a commit added after the import in Audit, the committed field looks like this:

1.png (148×364 px, 6 KB)

For commits from the same person before the import, it looks like:

2.png (132×333 px, 5 KB)

I am not sure if this is a bug or a feature. How do I associate the old commits with the committer so when I raise a concern, the committer will receive an email or a notification?

Event Timeline

foresightyj assigned this task to epriestley.
foresightyj raised the priority of this task from to Low.
foresightyj updated the task description. (Show Details)
foresightyj added a project: Audit.
foresightyj updated the task description. (Show Details)
foresightyj added a subscriber: foresightyj.
chad raised the priority of this task from Low to Needs Triage.

Update.

My Phabricator was installed in a virtual machine and yesterday the virtual file was corrupted so I had to install Phabricator again.

This time, I added all users first before I imported the SVN repo. I found that all committers were properly associated. So the observation is that when a commit is detected by phabricator, it will try to associate the committer's svn username with a user of the same username in Phabricator . If a particular user was not found at the time of the detected commit, even though the user was added later, Phabricator will not try to resolve old commits.

chad claimed this task.
chad added a subscriber: chad.

Thanks, that is our expectation as well. If you add users, you can always reparse commits from the command line tools.

Thanks a lot. For the rest who are interested, I just found that scripts/repository/reparse.php command does this. @epriestley mentioned it in the following stackoverflow thread:

http://stackoverflow.com/questions/21531192/arc-land-applying-with-wrong-user