Page MenuHomePhabricator

Projects are missing an internal apply implementation for edge transactions
Closed, ResolvedPublic

Description

  • Edit a project description, using @mentions to mention a user by username.
  • This fatals:

1[Tue Dec 09 17:49:31.511130 2014] [:error] [pid 7146] [client 10.64.0.172:32088] [2014-12-09 17:49:31] EXCEPTION: (Exception) Transaction type 'core:subscribers' is missing an internal apply implementation! at [<phabricator>/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php:484], referer: https://phabricator.wikimedia.org/project/details/929/
2[Tue Dec 09 17:49:31.511570 2014] [:error] [pid 7146] [client 10.64.0.172:32088] #0 PhabricatorApplicationTransactionEditor::applyCustomInternalTransaction(PhabricatorProject, PhabricatorProjectTransaction) called at [<phabricator>/src/applications/project/editor/PhabricatorProjectTransactionEditor.php:117], referer: https://phabricator.wikimedia.org/project/details/929/
3[Tue Dec 09 17:49:31.511586 2014] [:error] [pid 7146] [client 10.64.0.172:32088] #1 PhabricatorProjectTransactionEditor::applyCustomInternalTransaction(PhabricatorProject, PhabricatorProjectTransaction) called at [<phabricator>/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php:383], referer: https://phabricator.wikimedia.org/project/details/929/
4[Tue Dec 09 17:49:31.511595 2014] [:error] [pid 7146] [client 10.64.0.172:32088] #2 PhabricatorApplicationTransactionEditor::applyInternalEffects(PhabricatorProject, PhabricatorProjectTransaction) called at [<phabricator>/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php:686], referer: https://phabricator.wikimedia.org/project/details/929/
5[Tue Dec 09 17:49:31.511605 2014] [:error] [pid 7146] [client 10.64.0.172:32088] #3 PhabricatorApplicationTransactionEditor::applyTransactions(PhabricatorProject, array) called at [<phabricator>/src/applications/project/controller/PhabricatorProjectEditDetailsController.php:140], referer: https://phabricator.wikimedia.org/project/details/929/
6[Tue Dec 09 17:49:31.511614 2014] [:error] [pid 7146] [client 10.64.0.172:32088] #4 PhabricatorProjectEditDetailsController::processRequest() called at [<phabricator>/src/aphront/AphrontController.php:33], referer: https://phabricator.wikimedia.org/project/details/929/
7[Tue Dec 09 17:49:31.511623 2014] [:error] [pid 7146] [client 10.64.0.172:32088] #5 AphrontController::handleRequest(AphrontRequest) called at [<phabricator>/webroot/index.php:103], referer: https://phabricator.wikimedia.org/project/details/929/
8[Tue Dec 09 17:49:31.599205 2014] [:error] [pid 7146] [client 10.64.0.172:32088] PHP Fatal error: Uncaught exception 'Exception' with message 'Process exited with an open transaction! The transaction will be implicitly rolled back. Calls to openTransaction() must always be paired with a call to saveTransaction() or killTransaction().' in /srv/phab/libphutil/src/aphront/storage/connection/AphrontDatabaseTransactionState.php:69\nStack trace:\n#0 [internal function]: AphrontDatabaseTransactionState->__destruct()\n#1 {main}\n thrown in /srv/phab/libphutil/src/aphront/storage/connection/AphrontDatabaseTransactionState.php on line 69, referer: https://phabricator.wikimedia.org/project/details/929/
9[Tue Dec 09 17:49:36.597042 2014] [:error] [pid 11269] [client 10.64.0.172:32089] As received by the server, this request had a nonzero content length but no POST data.\n\nNormally, this indicates that it exceeds the 'post_max_size' setting in the PHP configuration on the server. Increase the 'post_max_size' setting or reduce the size of the request.\n\nRequest size according to 'Content-Length' was '288', 'post_max_size' is set to '10M'., referer: https://phabricator.wikimedia.org/project/details/929/
10[Tue Dec 09 17:49:41.596679 2014] [:error] [pid 7181] [client 10.64.0.172:32163] As received by the server, this request had a nonzero content length but no POST data.\n\nNormally, this indicates that it exceeds the 'post_max_size' setting in the PHP configuration on the server. Increase the 'post_max_size' setting or reduce the size of the request.\n\nRequest size according to 'Content-Length' was '288', 'post_max_size' is set to '10M'., referer: https://phabricator.wikimedia.org/project/details/929/
11[Tue Dec 09 17:49:46.596866 2014] [:error] [pid 7146] [client 10.64.0.172:32199] As received by the server, this request had a nonzero content length but no POST data.\n\nNormally, this indicates that it exceeds the 'post_max_size' setting in the PHP configuration on the server. Increase the 'post_max_size' setting or reduce the size of the request.\n\nRequest size according to 'Content-Length' was '288', 'post_max_size' is set to '10M'., referer: https://phabricator.wikimedia.org/project/details/929/

T6403 has a general discussion of this issue.

Fix is to add:

case blahblah::TYPE_EDGE:
  return;

...or simliar to applyInternal/applyExternal in ProjectEditor, if one of you gets there before I do.