Page MenuHomePhabricator

Transactions - fix bug in differential where older inlines weren't appearing
ClosedPublic

Authored by btrahan on Dec 5 2014, 6:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Apr 18 2026, 4:01 PM
Unknown Object (File)
Apr 17 2026, 3:33 PM
Unknown Object (File)
Apr 17 2026, 5:06 AM
Unknown Object (File)
Apr 16 2026, 8:09 AM
Unknown Object (File)
Mar 13 2026, 2:47 AM
Unknown Object (File)
Mar 10 2026, 11:38 AM
Unknown Object (File)
Feb 28 2026, 2:26 PM
Unknown Object (File)
Jan 31 2026, 5:12 AM
Subscribers

Details

Summary

Fixes T6699. We need to "loadInlineComments" consistently, though for an unexpected reason - this mutates the $changesets to include all $changesets that have an associated inline comment, which is necessary to make them render properly.

Test Plan

Took a diff with inline comments and updated it, noting the inline comments disappeared. applied this patch and the inlines reappeared.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable