Page MenuHomePhabricator

Transactions - fix bug in differential where older inlines weren't appearing
ClosedPublic

Authored by btrahan on Dec 5 2014, 6:19 PM.
Tags
None
Referenced Files
F18808229: D10935.id.diff
Sun, Oct 19, 5:38 AM
F18806519: D10935.diff
Sat, Oct 18, 8:00 PM
F18772640: D10935.id.diff
Thu, Oct 9, 3:29 AM
F18770245: D10935.id26263.diff
Wed, Oct 8, 11:32 AM
F18650180: D10935.id26263.diff
Sep 20 2025, 11:44 PM
F18646442: D10935.id26267.diff
Sep 19 2025, 9:57 AM
F18628228: D10935.id.diff
Sep 16 2025, 5:54 AM
F18624782: D10935.diff
Sep 15 2025, 9:03 PM
Subscribers

Details

Summary

Fixes T6699. We need to "loadInlineComments" consistently, though for an unexpected reason - this mutates the $changesets to include all $changesets that have an associated inline comment, which is necessary to make them render properly.

Test Plan

Took a diff with inline comments and updated it, noting the inline comments disappeared. applied this patch and the inlines reappeared.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable