Page MenuHomePhabricator

When deleting inline comments, offer "undo" instead of prompting
ClosedPublic

Authored by epriestley on Mar 9 2015, 10:59 PM.

Details

Summary

Ref T2009. Ref T1460.

Fixes T2618. When users hit "Delete" on inline comments, delete immediately and offer them "Undo". If they delete indirectly (e.g., by clicking "Delete" from the preview at the bottom of the page), we still prompt them, because the "Undo" action either won't be available or may not be easy to find. This is a "refdelete".

Fixes T6464. This was just a mess. Make it not as much of a mess. It should work now. Pretty sure.

Fixes T4999. We did not refresh these links often enough to find targets for them, so they could race with content. Reevaluate them after loading new changes.

Test Plan
  • Deleted and undid deletion of inlines from main view and preview.
  • Clicked "View" on inlines.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

btrahan accepted this revision.Mar 9 2015, 11:32 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 9 2015, 11:32 PM
This revision was automatically updated to reflect the committed changes.