Thanks, these offhand look incorrect to me too. cc @btrahan

I'm also curious about these exclamation mark icon colors next to auditor usernames in commit. I think badge color might be related to some in some way. Is there any documentation about Phabricator UI, e.g. what interface element means what?

One thing I haven't noticed from

In fact everything is connected. I've found, that blue exclamation mark next to auditor indicates, that audit is required (see https://github.com/phacility/phabricator/blob/master/src/applications/diffusion/controller/DiffusionCommitController.php#L1067-L1072) and dark exclamation mark next to auditor indicates that audit is requested (see https://github.com/phacility/phabricator/blob/master/src/applications/diffusion/controller/DiffusionCommitController.php#L1085-L1090).

So the problem is that auditors added by Heard rules now added as audit requested instead of audit required, which wrong IMO.

By the way what is that audit is requested status and how can I set one on a commit. I bet there was no such status before.

blue is incorrect anyways. It doesn't make sense to have it mean both AUDIT_REQUIRED and AUDIT_NOTREQUIRED. I have a diff to correct all the colors into something more sensible.

Also it's kind of strange to have orange badge (on commit list) for audit required status and blue exclamation mark (on commit detail page) at the same time.

D10726

Looks like a step in the right direction. Still doesn't explain Herald behavior change.

This explains how we prefer to write code:

https://secure.phabricator.com/book/phabflavor/article/recommendations_on_revision_control/#one-idea-is-one-commit

Specifically, it will take several commits to resolve this task as stated.