Audit / Herald - make audits added via herald "required"
ClosedPublic
Actions

Authored by btrahan on Oct 20 2014, 10:55 PM.

Details

Reviewers

epriestley
chad

Maniphest Tasks

T6345: No bar color for commits on Dashboard

Commits

Restricted Diffusion Commit
rPec82ad2d16ed: Audit / Herald - make audits added via herald "required"

Summary

as opposed to "requested". Also re-jigger how the "reason" works so the herald editor can get more specific data rather than a generic message. Fixes T6345 along with companion diff D10726.

Test Plan

made a herald rule to add auditors to a commit and saw it work!

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 25758.Oct 20 2014, 10:55 PM

btrahan added a task: T6345: No bar color for commits on Dashboard.

btrahan retitled this revision from to Audit / Herald - make audits added via herald "required".

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added reviewers: epriestley, chad.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptOct 20 2014, 10:55 PM

Screen_Shot_2014-10-20_at_3.55.11_PM.png (1×1 px, 344 KB)

Harbormaster completed remote builds in B2868: Diff 25758.Oct 20 2014, 10:56 PM

chad accepted this revision.Oct 20 2014, 11:02 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Oct 20 2014, 11:02 PM

Closed by commit rPec82ad2d16ed: Audit / Herald - make audits added via herald "required" (authored by btrahan, committed by btrahan). · Explain WhyOct 20 2014, 11:46 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

audit/

editor/

PhabricatorAuditEditor.php

18 lines

Diff 25759

View Options

src/applications/audit/editor/PhabricatorAuditEditor.php

Audit / Herald - make audits added via herald "required"ClosedPublicActions