Normalize AuditStatusConstant Colors
ClosedPublic
Actions

Authored by chad on Oct 18 2014, 8:50 PM.

Details

Reviewers

epriestley
btrahan

Maniphest Tasks

T6345: No bar color for commits on Dashboard

Commits

Restricted Diffusion Commit
rPeaf6ca3b6433: Normalize AuditStatusConstant Colors

Summary

Ref T6345, This adds more consistent color choices to match how Phabricator generally works across Differential/Diffusion per user statuses.

Test Plan

Review a few Audits in my sandbox.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 25752.Oct 18 2014, 8:50 PM

chad retitled this revision from to Normalize AuditStatusConstant Colors.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan.

chad added a task: T6345: No bar color for commits on Dashboard.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptOct 18 2014, 8:51 PM

Harbormaster completed remote builds in B2864: Diff 25752.Oct 18 2014, 8:51 PM

Harbormaster completed remote builds in B2864: Diff 25752.Oct 19 2014, 3:46 PM

btrahan accepted this revision.Oct 20 2014, 10:40 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Oct 20 2014, 10:40 PM

Closed by commit rPeaf6ca3b6433: Normalize AuditStatusConstant Colors (authored by chad, committed by chad). · Explain WhyOct 20 2014, 10:47 PM

This revision was automatically updated to reflect the committed changes.

btrahan mentioned this in D10730: Audit / Herald - make audits added via herald "required".Oct 20 2014, 10:55 PM

btrahan mentioned this in rPec82ad2d16ed: Audit / Herald - make audits added via herald "required".Oct 20 2014, 11:46 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

audit/

constants/

PhabricatorAuditStatusConstants.php

34 lines

differential/

view/

DifferentialReviewersView.php

2 lines

diffusion/

controller/

DiffusionCommitController.php

56 lines

Diff 25757

View Options

src/applications/audit/constants/PhabricatorAuditStatusConstants.php

View Options

src/applications/differential/view/DifferentialReviewersView.php

View Options

src/applications/diffusion/controller/DiffusionCommitController.php

Normalize AuditStatusConstant ColorsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 25757

src/applications/audit/constants/PhabricatorAuditStatusConstants.php

src/applications/differential/view/DifferentialReviewersView.php

src/applications/diffusion/controller/DiffusionCommitController.php

Normalize AuditStatusConstant Colors
ClosedPublic
Actions

Revision Contents
Changeset List