Page MenuHomePhabricator

Changes to E-mail Preferences adversely affected Audits
Closed, InvalidPublic

Description

In my Phabricator instance I have a personal Herald rule to add me as auditor on new commits. That works like a charm. However after recent Phabricator update I started to get an e-mail about every commit where I've been added as auditor OR maybe just every commit ever created. I haven't changed anything in setting to enable some additional e-mail notifications.

My guess is that, the E-mail preferences section was created or was changed to give you more control and now I'm getting e-mails for actions I haven't received them before.

Phabricator_EmailPreferences.png (314×459 px, 44 KB)

Since my own Herald rule added myself as auditor, then this should be considered as my own activity and I shouldn't get any e-mail notifications about it.

Here is how commit used to look before:

Phabricator_HowRegualarCommitLooks.png (484×1 px, 87 KB)

And here is how it looks now (new commit made after I updated Phabricator):

Phabricator_HowNewCommitLooks.png (605×1 px, 127 KB)

Obviously the "Commited ...." line isn't necessary, because it's commit we're looking at :)

From last image I can figure out that Herald is acting from it's own user and that's why I might be getting e-mail for "A commit has auditors added". I'm interested in that e-mail of course of new auditors were added, but not when my own Herard rule added me and notified myself about that fact :(

Event Timeline

aik099 raised the priority of this task from to Needs Triage.
aik099 updated the task description. (Show Details)
aik099 added projects: Audit, Profile.
aik099 updated the task description. (Show Details)
aik099 added a subscriber: aik099.

I guess T2497 task might be related. Before I wasn't getting much e-mails about audits, unless somebody added a comment/in-line comment.

chad claimed this task.

Audit was modernized recently to use the same frameworks as all other applications in Phabricator. It is now correctly sending emails when it previously did not.

Herald actions do not fall under 'actions I took', mostly because even if you built the rules, you did not take the action. When you take an action on Phabricator, you have direct knowledge of the transaction, but with Herald you do not, it's still a third party in the transaction.

Is there any way to determine which particular settings were responsible for that email? I have commit and auditor added mail tags on received email (header: X-Phabricator-Mail-Tags: <audit-commit>, <audit-add-auditors>).

Thanks.