Page MenuHomePhabricator

Bug in the faking of 'production.conf'
Closed, ResolvedPublic

Description

D10628 isn't working exactly right for me. The commit message says: "Allow phabricator_read_config_file(...) to continue working as though they exist so as to not break config-file-based installs." (We need this since our config-file-based install says: ... + phabricator_read_config_file('production')).

But when I tried to restart phabricator it said:

[2014-10-06 16:40:24] ERROR 2: include(/home/ubuntu/internal-webserver/phabricator/conf/production.conf.php): failed to open stream: No such file or directory at [/home/ubuntu/internal-webserver/phabricator/conf/__init_conf__.php:17]
#0 phabricator_read_config_file called at [<phabricator>/conf/__init_conf__.php:17]
#1 phabricator_read_config_file(string) called at [<phabricator>/conf/khan.conf.php:118]
#2 include(string) called at [<phabricator>/conf/__init_conf__.php:17]

Looking at D10628, it loks like it assumed include(foo) returns false if foo isn't found, but it looks like it raises an exception instead.

Event Timeline

csilvers raised the priority of this task from to Needs Triage.
csilvers updated the task description. (Show Details)
csilvers added a project: Phabricator.
csilvers added a subscriber: csilvers.
epriestley added a subscriber: epriestley.

Support Impact This breaks older installs which used phabricator_read_config_file(...) with any of the default config files when they attempt to upgrade.

well, actually I landed it so just update to HEAD and let me know if I didn't fix it. =D

Sorry, I've been having other phabricator fires today. And I changed my config to no longer import production.conf, so it's a bit hard for me to test it -- sorry!

No worries, I am very confident, and if someone hits it they'll report it. Thanks!