Page MenuHomePhabricator

Configuration - re-jigger how we handle bad configuration files
ClosedPublic

Authored by btrahan on Oct 6 2014, 8:14 PM.
Tags
None
Referenced Files
F15413703: D10643.id25558.diff
Wed, Mar 19, 8:43 PM
F15385948: D10643.id25558.diff
Fri, Mar 14, 11:44 PM
Unknown Object (File)
Fri, Feb 28, 5:11 PM
Unknown Object (File)
Feb 18 2025, 6:02 AM
Unknown Object (File)
Feb 7 2025, 11:39 PM
Unknown Object (File)
Feb 7 2025, 11:38 PM
Unknown Object (File)
Feb 7 2025, 11:38 PM
Unknown Object (File)
Feb 7 2025, 9:31 AM
Subscribers

Details

Summary

just explicitly check if the file doesn't exist *first*, and then do the standard include thing with the more generic error if that doesn't work. Fixes T6255.

Test Plan

re-started apache and phabricator still worked; will ask csilvers to give it a whirl too

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to Configuration - re-jigger how we handle bad configuration files.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Oct 6 2014, 8:15 PM
This revision was automatically updated to reflect the committed changes.