Differential D10643

Configuration - re-jigger how we handle bad configuration files
ClosedPublic
Actions

Authored by btrahan on Oct 6 2014, 8:14 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T6255: Bug in the faking of 'production.conf'

Commits

Restricted Diffusion Commit
rP69b1ff303238: Configuration - re-jigger how we handle bad configuration files

Summary

just explicitly check if the file doesn't exist *first*, and then do the standard include thing with the more generic error if that doesn't work. Fixes T6255.

Test Plan

re-started apache and phabricator still worked; will ask csilvers to give it a whirl too

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 25557.Oct 6 2014, 8:14 PM

btrahan added a task: T6255: Bug in the faking of 'production.conf'.

btrahan retitled this revision from to Configuration - re-jigger how we handle bad configuration files.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptOct 6 2014, 8:14 PM

btrahan mentioned this in T6255: Bug in the faking of 'production.conf'.Oct 6 2014, 8:14 PM

Harbormaster completed remote builds in B2755: Diff 25557.Oct 6 2014, 8:14 PM

epriestley accepted this revision.Oct 6 2014, 8:15 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Oct 6 2014, 8:15 PM

Closed by commit rP69b1ff303238: Configuration - re-jigger how we handle bad configuration files (authored by btrahan, committed by btrahan).Oct 6 2014, 8:15 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

conf/

__init_conf__.php

73 lines

Diff 25558

View Options

Configuration - re-jigger how we handle bad configuration filesClosedPublicActions