Page MenuHomePhabricator
Create Task
Maniphest T6017

Working copy check in Diffusion incorrectly reports that the repo has been deleted in Multiserver configuration
Closed, ResolvedPublic
Actions

Description

DiffusionRepositoryEditMainController.php explicitly access the repository directory on the current host, rather than using Conduit. This causes it to reporting incorrectly that the storage directory has been deleted.

The offending code looks like:

if ($repository->usesLocalWorkingCopy()) {
      $local_parent = dirname($repository->getLocalPath());
      if (Filesystem::pathExists($local_parent)) {

Related Objects
Search...

Event Timeline

hach-que created this task.Sep 2 2014, 7:33 AM
hach-que raised the priority of this task from to Normal.
hach-que updated the task description. (Show Details)
hach-que added subscribers: hach-que, epriestley.
epriestley added a comment.Sep 2 2014, 5:50 PM

Ah, good catch. We should probably add a Conduit method for this -- it's a bit low-level, but that seems fine.

epriestley renamed this task from Working copy check in Diffusion incorrectly reports that the repo has been deleted to Working copy check in Diffusion incorrectly reports that the repo has been deleted in Multiserver configuration.Sep 2 2014, 6:11 PM
epriestley added projects: Diffusion, Conduit.
epriestley closed this task as Resolved.Feb 19 2015, 5:25 PM
epriestley claimed this task.

This was fixed by D11102.

Phabricator · Built by Phacility