Page MenuHomePhabricator

Skip some repository checks in cluster enviornments
ClosedPublic

Authored by epriestley on Dec 31 2014, 7:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 8:46 AM
Unknown Object (File)
Tue, Dec 17, 6:45 AM
Unknown Object (File)
Thu, Dec 12, 6:54 PM
Unknown Object (File)
Fri, Dec 6, 12:00 AM
Unknown Object (File)
Thu, Dec 5, 11:53 PM
Unknown Object (File)
Thu, Dec 5, 11:09 PM
Unknown Object (File)
Mon, Dec 2, 11:23 AM
Unknown Object (File)
Thu, Nov 21, 1:23 PM
Subscribers

Details

Summary

Ref T2783. Currently, the repository edit page does some checks agaisnt the local system to look for binaries and files on disk. These checks don't make sense in a cluster environment.

Ideally, we could make a Conduit call to the host (e.g., add something like diffusion.querysetupstatus) to do these checks, but since they're pretty basic config things and cluster installs are advanced, it doesn't seem super worthwhile for now.

Test Plan

Saw fewer checks in a cluster repo.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Skip some repository checks in cluster enviornments.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
src/infrastructure/daemon/workers/query/PhabricatorWorkerArchiveTaskQuery.php
58

Unrelated fix, but this was a little buggy.

btrahan edited edge metadata.
This revision is now accepted and ready to land.Dec 31 2014, 7:49 PM
This revision was automatically updated to reflect the committed changes.