Page MenuHomePhabricator

Fix three issues with scrolling while dragging items (e.g., on workboards)
ClosedPublic

Authored by epriestley on Sep 9 2014, 8:53 PM.
Tags
None
Referenced Files
F14054290: D10455.diff
Fri, Nov 15, 11:49 PM
F14041545: D10455.diff
Mon, Nov 11, 7:35 PM
F14041402: D10455.id25143.diff
Mon, Nov 11, 6:13 PM
F14027436: D10455.diff
Fri, Nov 8, 7:11 AM
F14027380: D10455.diff
Fri, Nov 8, 6:57 AM
F14007801: D10455.id25147.diff
Tue, Oct 29, 11:46 AM
F14007800: D10455.id25143.diff
Tue, Oct 29, 11:46 AM
F14001192: D10455.diff
Fri, Oct 25, 5:03 AM
Subscribers
Tokens
"Yellow Medal" token, awarded by btrahan.

Details

Summary

Fixes T5979. There are three issues here:

  • We cache document positions when you pick an item up, but don't recalculate them after you scroll, so they get out of date. Dirty the cache when the user scrolls.
  • When we rebuild the cache during a drag (previously, this never happened), the position of the object you're dragging is computed wrong (since it has been moved to be under the cursor). Adjust the effective position of the object you've picked up to put it back in the right place in the list.
  • When you fiddle around at the bottom of a column you can get jumpy redraws as the height adjusts. Put min-height on the container during a drag to prevent this.
Test Plan

In Safari, Chrome and Firefox, dragged items around on columns before and after scrolling the workboard panel.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Fix three issues with scrolling while dragging items (e.g., on workboards).
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Sep 9 2014, 9:16 PM
epriestley updated this revision to Diff 25147.

Closed by commit rPf02aed10e769 (authored by @epriestley).