Page MenuHomePhabricator

When dragging stuff around, compensate for changes in scroll position

Authored by epriestley on Aug 7 2014, 11:41 PM.



Ref T5240. This fixes dragging stuff and using the mousewheel or keyboard to scroll the window during the drag.

(It does not fix "dragging near the edge of the container should scroll it" yet.)

Test Plan

Dragged stuff around on task list and workboards in Safari, Firefox and Chrome. Used mousewheel and shift + mousewheel to scroll the document and containers during drag. Object remained under the cursor.

Diff Detail

rP Phabricator
Lint Skipped
Tests Skipped

Event Timeline

epriestley retitled this revision from to When dragging stuff around, compensate for changes in scroll position.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
btrahan added inline comments.

Nice. This scroll stuff is a pain in the butt and this will help a ton.

This revision is now accepted and ready to land.Aug 8 2014, 10:35 PM
epriestley updated this revision to Diff 24558.

Closed by commit rP0e98e33b3342 (authored by @epriestley).