Page MenuHomePhabricator
Differential D10186

When dragging stuff around, compensate for changes in scroll position
ClosedPublic
Actions

Authored by epriestley on Aug 7 2014, 11:41 PM.
Tags
None
Referenced Files
F15471630: D10186.id24558.diff
Sat, Apr 5, 6:35 AM
F15457677: D10186.id24558.diff
Sun, Mar 30, 5:43 PM
F15457676: D10186.id24503.diff
Sun, Mar 30, 5:43 PM
F15427547: D10186.id.diff
Sun, Mar 23, 2:51 PM
F15391214: D10186.id24558.diff
Sat, Mar 15, 8:46 AM
F15387617: D10186.id24558.diff
Sat, Mar 15, 2:42 AM
F15380844: D10186.diff
Fri, Mar 14, 4:43 AM
F15353067: D10186.diff
Mon, Mar 10, 7:58 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T5240: Dragging items (cards, panels) could be better in Workboards
Commits
Restricted Diffusion Commit
rP0e98e33b3342: When dragging stuff around, compensate for changes in scroll position
Summary

Ref T5240. This fixes dragging stuff and using the mousewheel or keyboard to scroll the window during the drag.

(It does not fix "dragging near the edge of the container should scroll it" yet.)

Test Plan

Dragged stuff around on task list and workboards in Safari, Firefox and Chrome. Used mousewheel and shift + mousewheel to scroll the document and containers during drag. Object remained under the cursor.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 24503.Aug 7 2014, 11:41 PM
epriestley retitled this revision from to When dragging stuff around, compensate for changes in scroll position.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T5240: Dragging items (cards, panels) could be better in Workboards.
Herald added a subscriber: epriestley. · View Herald TranscriptAug 7 2014, 11:41 PM
Harbormaster completed remote builds in B2098: Diff 24503.Aug 7 2014, 11:43 PM
btrahan accepted this revision.Aug 8 2014, 10:35 PM
btrahan edited edge metadata.
btrahan added inline comments.
webroot/rsrc/externals/javelin/lib/Vector.js
312

Nice. This scroll stuff is a pain in the butt and this will help a ton.

This revision is now accepted and ready to land.Aug 8 2014, 10:35 PM
epriestley closed this revision.Aug 9 2014, 3:49 PM
epriestley updated this revision to Diff 24558.

Closed by commit rP0e98e33b3342 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
resources/
celerity/
52 lines
webroot/
rsrc/
externals/
javelin/
lib/
29 lines
js/
core/
10 lines

Diff 24558

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/externals/javelin/lib/Vector.js

Loading...
View Options

webroot/rsrc/js/core/DraggableList.js

Loading...
Phabricator · Built by Phacility