This prevents crashes when looking at builds, where the build steps have been deleted on the build plan since the build was run. Currently the only information that's pulled from the build step is the description (because this was too large to copy to every target).
- Group Reviewers
- Maniphest Tasks
- T5866: Crash when viewing a build, whose build plan has had steps deleted
- Restricted Diffusion Commit
rP0e15393b466e: Prevent crash when build step has been deleted on build plan
Tested it locally.
You can HarbormasterBuildStep $step = null to allow null. This has the downside of making the method work without parameters, but I think that's a little better on the balance than losing the typehint completely.