Page MenuHomePhabricator

Prevent crash when build step has been deleted on build plan
ClosedPublic

Authored by hach-que on Aug 27 2014, 12:18 AM.

Details

Summary

This prevents crashes when looking at builds, where the build steps have been deleted on the build plan since the build was run. Currently the only information that's pulled from the build step is the description (because this was too large to copy to every target).

Test Plan

Tested it locally.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

hach-que retitled this revision from to Prevent crash when build step has been deleted on build plan.
hach-que updated this object.
hach-que edited the test plan for this revision. (Show Details)
hach-que added a reviewer: epriestley.
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/harbormaster/storage/build/HarbormasterBuildTarget.php
120

You can HarbormasterBuildStep $step = null to allow null. This has the downside of making the method work without parameters, but I think that's a little better on the balance than losing the typehint completely.

This revision is now accepted and ready to land.Aug 27 2014, 7:14 PM
hach-que edited edge metadata.

Update based on feedback

hach-que updated this revision to Diff 24965.

Closed by commit rP0e15393b466e (authored by @hach-que).