Prevent crash when build step has been deleted on build plan
ClosedPublic
Actions

Authored by hach-que on Aug 27 2014, 12:18 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T5866: Crash when viewing a build, whose build plan has had steps deleted

Commits

Restricted Diffusion Commit
rP0e15393b466e: Prevent crash when build step has been deleted on build plan

Summary

This prevents crashes when looking at builds, where the build steps have been deleted on the build plan since the build was run. Currently the only information that's pulled from the build step is the description (because this was too large to copy to every target).

Test Plan

Tested it locally.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

hach-que updated this revision to Diff 24944.Aug 27 2014, 12:18 AM

hach-que retitled this revision from to Prevent crash when build step has been deleted on build plan.

hach-que updated this object.

hach-que edited the test plan for this revision. (Show Details)

hach-que added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 27 2014, 12:18 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B2359: Diff 24944.Aug 27 2014, 12:19 AM

epriestley accepted this revision.Aug 27 2014, 7:14 PM

epriestley edited edge metadata.

epriestley added inline comments.

src/applications/harbormaster/storage/build/HarbormasterBuildTarget.php
120	You can `HarbormasterBuildStep $step = null` to allow `null`. This has the downside of making the method work without parameters, but I think that's a little better on the balance than losing the typehint completely.