Only show text encoding note in Differential if a change has hunks
ClosedPublic
Actions

Authored by epriestley on Jun 29 2014, 5:24 PM.

Details

Reviewers

joshuaspence
btrahan

Maniphest Tasks

T5503: Empty file has an unknown character encoding

Commits

Restricted Diffusion Commit
rPc1af499ed7ab: Only show text encoding note in Differential if a change has hunks

Summary

Fixes T5503. We incorrectly render an encoding note for empty files. Only render an encoding note for text changes with at least one hunk.

Test Plan

Viewed empty file, no note.
Viewed nonempty file with altered encoding, saw note.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 23478.Jun 29 2014, 5:24 PM

epriestley retitled this revision from to Only show text encoding note in Differential if a change has hunks.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: joshuaspence, btrahan.

epriestley added a task: T5503: Empty file has an unknown character encoding.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 29 2014, 5:24 PM

Harbormaster completed remote builds in B1462: Diff 23478.Jun 29 2014, 5:25 PM

LGTM. Thanks

This revision is now accepted and ready to land.Jun 29 2014, 6:15 PM

Closed by commit rPc1af499ed7ab (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

render/

DifferentialChangesetHTMLRenderer.php

25 lines

Diff 23479

View Options

src/applications/differential/render/DifferentialChangesetHTMLRenderer.php

Only show text encoding note in Differential if a change has hunksClosedPublicActions