Page MenuHomePhabricator
Differential D9388

Allow triple backticks to be preceded by whitespace.
ClosedPublic
Actions

Authored by joshuaspence on Jun 5 2014, 8:11 AM.
Tags
None
Referenced Files
F13168877: D9388.diff
Tue, May 7, 8:00 AM
Unknown Object (File)
Fri, May 3, 8:51 AM
Unknown Object (File)
Wed, May 1, 7:52 AM
Unknown Object (File)
Fri, Apr 26, 2:52 AM
Unknown Object (File)
Fri, Apr 26, 2:52 AM
Unknown Object (File)
Fri, Apr 26, 2:52 AM
Unknown Object (File)
Wed, Apr 24, 11:19 PM
Unknown Object (File)
Sat, Apr 20, 7:00 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T5264: Quoting a code block does not work as expected
Commits
rPHU120a050b9251: Allow triple backticks to be preceded by whitespace.
Summary

Fixes T5264. Allows triple backticks to be preceded by whitespace in a code block. This fixes the display of quoted code blocks, which are regular code blocks prefied with > .

Test Plan

Wrote and executed unit tests.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 22387.Jun 5 2014, 8:11 AM
joshuaspence retitled this revision from to Allow triple backticks to be preceded by whitespace..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T5264: Quoting a code block does not work as expected.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 5 2014, 8:11 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B868: Diff 22387.Jun 5 2014, 8:12 AM
joshuaspence added a comment.Jun 5 2014, 8:15 AM

quote.png (425×1 px, 27 KB)

epriestley accepted this revision.Jun 5 2014, 4:49 PM
epriestley edited edge metadata.

Thanks!

This revision is now accepted and ready to land.Jun 5 2014, 4:49 PM
epriestley closed this revision.Jun 5 2014, 4:49 PM
epriestley updated this revision to Diff 22396.

Closed by commit rPHU120a050b9251 (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

PathSize
4 lines
src/
markup/
engine/
__tests__/
remarkup/
22 lines
remarkup/
blockrule/
9 lines

Diff 22396

View Options

.editorconfig

Loading...
View Options

src/markup/engine/__tests__/remarkup/quoted-code-block.txt

Loading...
View Options

src/markup/engine/remarkup/blockrule/PhutilRemarkupEngineRemarkupCodeBlockRule.php

Loading...
Phabricator · Built by Phacility