Fix changeset layout in Modern Firefox
ClosedPublic
Actions

Authored by chad on May 21 2014, 6:04 PM.

Details

Reviewers

epriestley
btrahan

Maniphest Tasks

T4987: Overflow in .differential-changeset causes dual scrollbars and interrupted scrolling

Commits

Restricted Diffusion Commit
rP2ad501873ae4: Fix changeset layout in Modern Firefox

Summary

Looks like a rule for old Firefox is causing layout issues in new Firefox. Prefer new Firefox. Fixes T4987

Test Plan

Tested the current version of Firefox.

Bug:

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

chad updated this revision to Diff 21946.May 21 2014, 6:04 PM

chad retitled this revision from to Fix changeset layout in Modern Firefox.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan.

chad added a task: T4987: Overflow in .differential-changeset causes dual scrollbars and interrupted scrolling.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptMay 21 2014, 6:04 PM

chad edited the test plan for this revision. (Show Details)May 21 2014, 6:04 PM

Harbormaster completed remote builds in B633: Diff 21946.May 21 2014, 6:05 PM

Ummm, wow. I don't even know what to say... haha. This ends up breaking almost nobody, right? (That is, almost nobody uses Firefox versions that need this?)

I'm down to accept though I have no idea on this piece of cryptic browser buggery so its on faith. =D

If you make a diff with, like, "fifltitloellilaeff", do each of those letters render as a full-width character with no ligatures?

It looks like this was probably something specific to ProFont, possibly: https://bugzilla.mozilla.org/show_bug.cgi?id=384395

This revision is now accepted and ready to land.May 21 2014, 8:32 PM

Closed by commit rP2ad501873ae4 (authored by @chad).

epriestley mentioned this in T7690: Unnecessary scroll bars for changesets in Firefox.Mar 30 2015, 6:52 PM

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

6 lines

webroot/

rsrc/

css/

application/

differential/

changeset-view.css

11 lines

Diff 21959

View Options

resources/celerity/map.php