Page MenuHomePhabricator

Reload subscribers before sending mail, etc
ClosedPublic

Authored by epriestley on Mar 18 2014, 10:51 PM.

Details

Summary

Fixes T4629. CCs added by Herald don't get added to the cached subscriber list. Just reload subscribers before sending mail to pick up effects.

Test Plan

Created an "always add X as CC" Herald rule for revisions, created a revision, saw them get initial mail.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

epriestley retitled this revision from to Reload subscribers before sending mail, etc.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.

I was worried about doing this but I can't think of any cases where subscribers are added and *should not* be notified at the time they are added...? Maybe some folks might report getting emails when they subscribe to stuff and they weren't before or something.

This revision is now accepted and ready to land.Mar 18 2014, 10:57 PM

I think it has always been intended to work like this in all cases, it just got a bit mucked up with T2222 and the Herald / sub-editor stuff interacting with the local cache on the Editor.

epriestley updated this revision to Diff 20331.

Closed by commit rP833b8a78d89f (authored by @epriestley).