Fixes T4629. CCs added by Herald don't get added to the cached subscriber list. Just reload subscribers before sending mail to pick up effects.
- Maniphest Tasks
- T4629: Herald: Not receiving email on diff creation
- Restricted Diffusion Commit
rP833b8a78d89f: Reload subscribers before sending mail, etc
Created an "always add X as CC" Herald rule for revisions, created a revision, saw them get initial mail.
I was worried about doing this but I can't think of any cases where subscribers are added and *should not* be notified at the time they are added...? Maybe some folks might report getting emails when they subscribe to stuff and they weren't before or something.