Page MenuHomePhabricator

arc amend marking diffs as closed
Closed, DuplicatePublic


Not sure if this is a bug in arc or differential or both.

  1. Brent submits diff -> diff status is "Needs Review"
  2. Evan accepts diff -> diff status is "Accepted"
  3. Brent runs arc amend -> diff status changes to "Closed"
  4. Brent runs arc land -> arc presents a warning Revision 'D123: my terrible diff' has not been accepted. Continue anyway? [y/N]

Why is step 3 changing the status from "Accepted" to "Closed" before the diff was committed?
Why is step 4 getting in the way of me committing a diff? That message looks like it should only come up for pre-accepted diffs. A post-accepted status (i.e., "Closed") should still be committable.

Event Timeline

brent assigned this task to epriestley.
brent raised the priority of this task from to Needs Triage.
brent updated the task description. (Show Details)
brent added a project: Differential.
brent added a subscriber: brent.
brent renamed this task from arc commit bug to arc amend marking diffs as closed.Nov 27 2013, 11:01 AM

The short fix here is:

  • Go to the "Repositories" tool.
  • Scroll down to the bottom of the page.
  • Find the "Arcanist Project" associated with the code you want to run arc amend in.
  • Click "Edit".
  • Associate it with the correct "Repository".
  • Click "Save".
  • arc amend will no longer close revisions in this project.

The long version is:


  • This behavior is really old and should probably be removed. It predates the existence of arc close-revision, "Close" from the web UI, etc.
  • The sequence of configuration steps above is ridiculous, not at all obvious, and going away soon.
  • We figure out repositories automatically now in most cases.
  • arc amend no longer closes things.
  • arc land now uses the smarter heuristics.