Page MenuHomePhabricator

Use more modern detection of repositories in "arc close-revision"
ClosedPublic

Authored by epriestley on Mar 14 2014, 12:38 AM.
Tags
None
Referenced Files
F14093892: D8523.id20220.diff
Mon, Nov 25, 1:16 PM
Unknown Object (File)
Oct 20 2024, 3:01 PM
Unknown Object (File)
Oct 20 2024, 2:43 AM
Unknown Object (File)
Oct 18 2024, 10:38 AM
Unknown Object (File)
Oct 18 2024, 1:04 AM
Unknown Object (File)
Oct 17 2024, 11:45 PM
Unknown Object (File)
Oct 17 2024, 11:26 PM
Unknown Object (File)
Oct 17 2024, 11:25 PM
Subscribers

Details

Summary

Fixes T4603. We fire arc close-revision --finalize implicitly from arc land, which may close a corresponding Differential revision.

We want to close if the repository is not present in Phabricator (i.e., we'll never be able to close in response to the commit message, since we'll never see it). Historically, we used Arcanist Project -> "Tracked" to make this determination. Instead, just check if the working copy is associated with a repository. This is simpler, easier, and works better.

Test Plan

Ran arc close-revision --finalize.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Use more modern detection of repositories in "arc close-revision".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 14 2014, 12:42 AM
epriestley updated this revision to Diff 20226.

Closed by commit rARC1e6d958b27df (authored by @epriestley).