If a user has a bookmark named 'arcpatch' in their mercurial repository already, 'arc patch D1234' fails to find a valid name. This is likely due to the lack of escaping in ArcanistPatchWorkflow::getBookmarkName (https://secure.phabricator.com/diffusion/ARC/browse/master/src/workflow/ArcanistPatchWorkflow.php$267) and mercurial sees arcpatch-D1234 as a query instead of a name. Using phabricator's hgsprintf to create the query should fix it.
Description
Description
Revisions and Commits
Revisions and Commits
Related Objects
Related Objects
- Duplicates Merged Here
- T4711: `arc patch` with mercurial generates a doubly quoted bookmark name
Event Timeline
Comment Actions
I can't immediately reproduce this, but maybe it's a version issue. D8512 should fix it.