Page MenuHomePhabricator

arc patch should use hgsprintf for bookmarks
Closed, ResolvedPublic

Description

If a user has a bookmark named 'arcpatch' in their mercurial repository already, 'arc patch D1234' fails to find a valid name. This is likely due to the lack of escaping in ArcanistPatchWorkflow::getBookmarkName (https://secure.phabricator.com/diffusion/ARC/browse/master/src/workflow/ArcanistPatchWorkflow.php$267) and mercurial sees arcpatch-D1234 as a query instead of a name. Using phabricator's hgsprintf to create the query should fix it.

Event Timeline

durham raised the priority of this task from to Needs Triage.
durham updated the task description. (Show Details)
durham added a project: Arcanist.
durham added a subscriber: durham.

I can't immediately reproduce this, but maybe it's a version issue. D8512 should fix it.

Sorry, my fix for this was completely wrong and I misunderstood the report.