Page MenuHomePhabricator

`arc patch` with mercurial generates a doubly quoted bookmark name
Closed, DuplicatePublic

Description

Since rARC67239a08a58f (fix for T4596) our bookmark names generated by arc patch are surrounded by extra quotes.

This seems quite useless and silly.

Event Timeline

rvanvelzen assigned this task to epriestley.
rvanvelzen raised the priority of this task from to Low.
rvanvelzen updated the task description. (Show Details)
rvanvelzen added a project: Arcanist.
rvanvelzen added a subscriber: rvanvelzen.

Hmm, what version of Mercurial are you running? I don't think I've observed this locally, so I wonder if it's a version issue.

Mercurial Distributed SCM (version 2.8.2)

The output of arc --trace patch 615:

richard @richard-ubuntu[/var/repo/experty] (experty@qa-interface)
-> arc --trace patch 615
libphutil loaded from '/opt/arc/libphutil/src'.
arcanist loaded from '/opt/arc/arcanist/src'.
Working Copy: Reading .arcconfig from "/var/repo/experty/.arcconfig".
Working Copy: Path "/var/repo/experty" is part of `hg` working copy "/var/repo/experty".
Working Copy: Project root is at "/var/repo/experty".
Loading phutil library from '/var/repo/experty/support/arcanist'...
>>> [0] <conduit> differential.getdiff() <bytes = 68>
>>> [1] <http> http://phabricator.expert-shops.com/api/differential.getdiff
<<< [1] <http> 86,478 us
<<< [0] <conduit> 86,897 us
>>> [2] <conduit> conduit.connect() <bytes = 454>
>>> [3] <http> http://phabricator.expert-shops.com/api/conduit.connect
<<< [3] <http> 73,088 us
<<< [2] <conduit> 73,584 us
>>> [4] <conduit> differential.getdiff() <bytes = 190>
>>> [5] <http> http://phabricator.expert-shops.com/api/differential.getdiff
<<< [5] <http> 134,336 us
<<< [4] <conduit> 134,891 us
>>> [6] <conduit> arcanist.projectinfo() <bytes = 187>
>>> [7] <http> http://phabricator.expert-shops.com/api/arcanist.projectinfo
<<< [7] <http> 70,142 us
<<< [6] <conduit> 70,649 us
>>> [8] <exec> $ HGPLAIN=1 hg status
<<< [8] <exec> 124,398 us
>>> [9] <exec> $ HGPLAIN=1 hg log -l 1 --template '{node}' -r '134621ac4298c9d927d9000cb2194e2ad008d577' --
<<< [9] <exec> 51,096 us
>>> [10] <exec> $ HGPLAIN=1 hg bookmarks
<<< [10] <exec> 48,974 us
>>> [11] <exec> $ HGPLAIN=1 hg log -r 'arcpatch-D615'
<<< [11] <exec> 54,738 us
>>> [12] <exec> $ HGPLAIN=1 hg log -l 1 --template '{node}' -r '134621ac4298c9d927d9000cb2194e2ad008d577' --
<<< [12] <exec> 49,957 us
Updating to the revision's base commit
>>> [13] <exec> $ HGPLAIN=1 hg update ''\''134621ac4298c9d927d9000cb2194e2ad008d577'\'''
3 files updated, 0 files merged, 0 files removed, 0 files unresolved
<<< [13] <exec> 127,060 us
>>> [14] <exec> $ HGPLAIN=1 hg bookmark ''\''arcpatch-D615'\'''
<<< [14] <exec> 58,589 us
Created and checked out bookmark arcpatch-D615.
>>> [15] <exec> $ HGPLAIN=1 hg log -l 1 --template '{node}' -r '134621ac4298c9d927d9000cb2194e2ad008d577' --
<<< [15] <exec> 48,991 us
>>> [16] <exec> $ HGPLAIN=1 hg import --no-commit -
<<< [16] <exec> 124,054 us
>>> [17] <conduit> differential.getcommitmessage() <bytes = 190>
>>> [18] <http> http://phabricator.expert-shops.com/api/differential.getcommitmessage
<<< [18] <http> 101,263 us
<<< [17] <conduit> 101,664 us
>>> [19] <exec> $ HGPLAIN=1 hg commit  -l -
<<< [19] <exec> 238,949 us
OKAY  Successfully committed patch.

As you can see the given argument for bookmark is ''\''arcpatch-D615'\''', which is doubly escaped.