Paths

Table of Contentst

Use hgsprintf() when managing bookmarks in arc patch in mercurial
ClosedPublic
Actions

Authored by epriestley on Mar 12 2014, 11:11 PM.

Tags

None

Referenced Files

	F13210312: D8512.diff
	Fri, May 17, 4:42 AM

	F13206337: D8512.id.diff
	Wed, May 15, 7:12 AM

	F13206136: D8512.diff
	Wed, May 15, 5:30 AM

	F13194094: D8512.diff
	Sun, May 12, 9:18 PM

	F13177174: D8512.diff
	Wed, May 8, 7:31 PM

	Unknown Object (File)
	Tue, May 7, 4:42 PM

	Unknown Object (File)
	Tue, Apr 30, 11:47 PM

	Unknown Object (File)
	Mon, Apr 29, 1:44 PM

View All Files

Subscribers

aran

epriestley

Details

Reviewers

btrahan
durham

Maniphest Tasks

T4596: arc patch should use hgsprintf for bookmarks

Commits

rARC67239a08a58f: Use hgsprintf() when managing bookmarks in arc patch in mercurial

Summary

Fixes T4596. I couldn't immediately reproduce this, but the hgsprintf() version is clearly more correct.

Test Plan

Used arc patch --trace to examine hg commands.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 20192.Mar 12 2014, 11:11 PM

epriestley retitled this revision from to Use hgsprintf() when managing bookmarks in arc patch in mercurial.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: btrahan, durham.

epriestley added a task: T4596: arc patch should use hgsprintf for bookmarks.

Herald added subscribers: epriestley, aran.Mar 12 2014, 11:11 PM

durham accepted this revision.Mar 12 2014, 11:16 PM

durham edited edge metadata.

This revision is now accepted and ready to land.Mar 12 2014, 11:16 PM

Closed by commit rARC67239a08a58f (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistPatchWorkflow.php

4 lines

Diff 20204

View Options

src/workflow/ArcanistPatchWorkflow.php

Use hgsprintf() when managing bookmarks in arc patch in mercurialClosedPublicActions