Page MenuHomePhabricator

Add policy to Pholio
Closed, ResolvedPublic

Description

Currently, Pholio allows only users who created the mock to edit and/or delete it.

It seems beneficial for a multi-designer team to allow a group or even everyone to change th mocks.

Applying a policy (perhaps Maniphest style) to edit / view should allow for this usecase.

Event Timeline

boruchy raised the priority of this task from to Normal.
boruchy updated the task description. (Show Details)
boruchy added a project: Pholio.
boruchy added a subscriber: boruchy.

@chad - this would imply that the owner of a mock could change from the creator. are you cool with that?

if the product should head this direction, technically the work involved is something like

  • TYPE_OWNER to PholioTransactions
  • owner UI element to detail / edit
  • Policy control for "edit"
  • Making sure PholioTransaction don't make any assumptions about authorPHID vs ownerPHID incorrectly
btrahan raised the priority of this task from Normal to Needs Triage.

As long as there is an audit trail, that's fine. I would assume people would self police here.

btrahan triaged this task as Normal priority.
chad lowered the priority of this task from Normal to Low.Mar 21 2014, 5:22 AM
chad moved this task to On Deck on the Pholio board.

D9550 implements a configurable edit policy. It does not implement a mutable/separate "owner" field, because it's not clear that it would really be useful right now.

We may add an owner field in the future -- for example, if we add more workflow options to Pholio (like review/accept/reject, etc) such that the owner is meaningful, it would make sense to make it mutable. At the moment we don't have any concrete plans around expanding workflow, though, and I think all the requests we've seen are focused on collaborating/sharing, which should be easier now.

The default policy has been relaxed: previously, it was (implicitly) just the author. It now defaults to "All Users". The default can be changed in Applications > Pholio > Help/Options > Edit Policies. Existing mocks have had their policies preserved, but new mocks will start with the default policy.