Page MenuHomePhabricator

Give Pholio mocks a configurable edit policy
ClosedPublic

Authored by epriestley on Jun 15 2014, 4:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 3, 2:42 AM
Unknown Object (File)
Mon, Apr 29, 2:09 PM
Unknown Object (File)
Wed, Apr 24, 9:59 PM
Unknown Object (File)
Wed, Apr 24, 7:03 AM
Unknown Object (File)
Sat, Apr 20, 7:05 PM
Unknown Object (File)
Tue, Apr 9, 6:25 PM
Unknown Object (File)
Apr 1 2024, 10:31 PM
Unknown Object (File)
Feb 16 2024, 9:02 PM
Subscribers

Details

Reviewers
chad
Maniphest Tasks
T4566: Add policy to Pholio
Commits
Restricted Diffusion Commit
rP868ff166b109: Give Pholio mocks a configurable edit policy
Summary

Ref T4566. Currently, mocks have a conservative (author only), immutable default edit policy.

Instead:

  • Let the edit policy be changed.
  • Default the edit policy to "all users", similar to other applications.
  • Add an application-level setting for it.
  • Migrate existing edit policies to be consistent with the old policy (just the author).

This stops short of adding a separate "owner" and letting that be changed, since Pholio doesn't really have any review/approve type features (at least, so far). We can look at doing this if we get more feedback about it, or if we make owners more meaningful (e.g., add more "review-like" process to mocks).

Test Plan
  • Ran migration scripts.
  • Confirmed existing mocks retained their effective policies (author only).
  • Created a new mock, saw edit policy.
  • Changed edit policy.
  • Changed global edit policy default.
  • Tried to edit a mock I couldn't edit.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Give Pholio mocks a configurable edit policy.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 15 2014, 5:24 PM
epriestley updated this revision to Diff 22889.

Closed by commit rP868ff166b109 (authored by @epriestley).