Page MenuHomePhabricator

User reporting "The owner of a revision may not be a reviewer." error despite not adding self as reviewer
Closed, ResolvedPublic

Description

A user on IRC is reporting receiving the error message:

ERR-CONDUIT-CORE: The owner of a revision may not be a reviewer.

...after running arc diff to create a new revision. The commit message did not appear to add them as a reviewer.

A theory I had is that Herald might be adding them as a reviewer, but the user reported that there were no transcripts. It's still possible this is the case if failing the update stops Herald from saving the transcript. This is probably worth looking into.

The message could also be more clear (e.g., enumerate all the offending parties).

Event Timeline

epriestley raised the priority of this task from to Needs Triage.
epriestley updated the task description. (Show Details)
epriestley added a project: Differential.
epriestley added a subscriber: epriestley.

This error message isn't easy to improve until after T3886, since we don't have the viewing user and thus can't make privacy-aware queries to look up the reviewer names.

epriestley claimed this task.

I'm going to assume this is fixed since everything was rewritten with T3886 / T2222 and I haven't seen any further reports.