Page MenuHomePhabricator
Differential D15754

Consolidate handling of SSH usernames
ClosedPublic
Actions

Authored by epriestley on Apr 19 2016, 1:03 PM.
Tags
None
Referenced Files
F18749638: D15754.diff
Sat, Oct 4, 4:34 AM
F18679716: D15754.id37973.diff
Fri, Sep 26, 1:24 AM
F18678602: D15754.diff
Thu, Sep 25, 10:52 PM
F18677537: D15754.id.diff
Thu, Sep 25, 9:14 PM
F18642852: D15754.id37962.diff
Fri, Sep 19, 12:55 AM
F18594582: D15754.diff
Fri, Sep 12, 6:40 PM
F18588014: D15754.diff
Thu, Sep 11, 11:04 PM
F18407563: D15754.id.diff
Aug 30 2025, 1:08 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T4292: Implement repository replication
Commits
rP0db6eaca4173: Consolidate handling of SSH usernames
Summary

Ref T4292. This consolidates code for figuring out which user we should connect to hosts with.

Also narrows a lock window.

Test Plan

Browsed Diffusion, pulled and pushed through an SSH proxy.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 37962.Apr 19 2016, 1:03 PM
epriestley retitled this revision from to Consolidate handling of SSH usernames.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T4292: Implement repository replication.
chad accepted this revision.Apr 19 2016, 5:23 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 19 2016, 5:23 PM
Closed by commit rP0db6eaca4173: Consolidate handling of SSH usernames (authored by epriestley, committed by epriestley). · Explain WhyApr 19 2016, 8:04 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T10751: Make Phabricator Highly Available.Apr 19 2016, 9:29 PM
epriestley mentioned this in T13529: Phacility domain rename errata and SSH user identity.May 12 2020, 6:20 PM

Revision Contents
Changeset List

PathSize
src/
applications/
almanac/
util/
18 lines
diffusion/
ssh/
15 lines
repository/
storage/
11 lines
2 lines

Diff 37973

View Options

src/applications/almanac/util/AlmanacKeys.php

Loading...
View Options

src/applications/diffusion/ssh/DiffusionSSHWorkflow.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepository.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepositoryURI.php

Loading...
Phabricator · Built by Phacility