Work around "mb_check_encoding(<stringlike-object>)" warning in particular versions of PHP
ClosedPublic
Actions

Authored by epriestley on Apr 30 2020, 2:14 PM.

Details

Reviewers: None
Maniphest Tasks: T13527: "mb_check_encoding()" may rase a warning if passed an object which implements "__toString()"
Commits: rARCc1d12ff7784b: (stable) Work around "mb_check_encoding(<stringlike-object>)" warning in…
rARC696ec3f97585: Work around "mb_check_encoding(<stringlike-object>)" warning in particular…

Summary

Fixes T13527. Some versions of PHP strictly require that we pass a string value, and reject "stringlike" objects (objects which implement "__toString()").

Test Plan

Ran unit test, although this is somewhat aspirational because my local PHP version isn't affected.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 30 2020, 2:14 PM

Harbormaster completed remote builds in B24287: Diff 50472.Apr 30 2020, 2:15 PM

epriestley requested review of this revision.Apr 30 2020, 2:15 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 30 2020, 2:19 PM

Closed by commit rARC696ec3f97585: Work around "mb_check_encoding(<stringlike-object>)" warning in particular… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC696ec3f97585: Work around "mb_check_encoding(<stringlike-object>)" warning in particular….

epriestley added a commit: rARCc1d12ff7784b: (stable) Work around "mb_check_encoding(<stringlike-object>)" warning in….

Revision Contents
Changeset List

Path

Size

src/

utils/

__tests__/

PhutilUTF8TestCase.php

9 lines

utf8.php

4 lines

Diff 50473

View Options

src/utils/tests/PhutilUTF8TestCase.php

View Options

Work around "mb_check_encoding(<stringlike-object>)" warning in particular versions of PHPClosedPublicActions