Page MenuHomePhabricator
Create Task
Maniphest T13476

Correct vertical spacing issues when some components wrap across a line break
Closed, ResolvedPublic
Actions

Description

See PHI1596, which reports tags rendering with an overlap in object headers when they wrap, particularly on devices:

Screen Shot 2020-01-14 at 6.31.52 PM.png (205×518 px, 31 KB)

To reproduce this:

  • Give a project a very long name.
  • Set a task's "View Policy" to the project.
  • View the task on a narrow screen.

A similar issue occurs when the "Visible To" control wraps with spaces enabled:

Screen Shot 2020-01-14 at 7.12.43 AM.png (128×417 px, 12 KB)

To reproduce this:

  • Enable Spaces.
  • View the edit form of an object with a mutable view policy (like a task, normally).
  • Narrow your screen.

Revisions and Commits

rP Phabricator
D20944rPd0b01a41f249 Fix two issues with missing whitespace when elements stack on top of each other…

Related Objects

Event Timeline

epriestley triaged this task as Low priority.Jan 15 2020, 2:33 AM
epriestley created this task.
Herald added a subscriber: amckinley. · View Herald TranscriptJan 15 2020, 2:33 AM
epriestley added a comment.Jan 15 2020, 4:46 PM

A similar issue occurs when the "Visible To" control wraps with spaces enabled. To reproduce this...

These reproduction instructions are insufficient. The normal edit form is actually fine, it's only when the edit form appears in a dialog, ala Harbormaster → Add Build Step → Add New Credential.

Fixing this completely correctly in the general case is a little tricky and probably requires adding a new set of wrapper divs that are definitely not a table.

For now, I'm tweaking margins a little to get mostly-better behavior.

epriestley added a revision: D20944: Fix two issues with missing whitespace when elements stack on top of each other while wrapping.Jan 15 2020, 4:48 PM
epriestley closed this task as Resolved by committing rPd0b01a41f249: Fix two issues with missing whitespace when elements stack on top of each other….Jan 15 2020, 4:53 PM
epriestley added a commit: rPd0b01a41f249: Fix two issues with missing whitespace when elements stack on top of each other….
epriestley mentioned this in 2020 Week 5 (Very Late January).Jan 30 2020, 9:35 PM
Phabricator · Built by Phacility