Page MenuHomePhabricator

Correct vertical spacing issues when some components wrap across a line break
Closed, ResolvedPublic


See PHI1596, which reports tags rendering with an overlap in object headers when they wrap, particularly on devices:

Screen Shot 2020-01-14 at 6.31.52 PM.png (205×518 px, 31 KB)

To reproduce this:

  • Give a project a very long name.
  • Set a task's "View Policy" to the project.
  • View the task on a narrow screen.

A similar issue occurs when the "Visible To" control wraps with spaces enabled:

Screen Shot 2020-01-14 at 7.12.43 AM.png (128×417 px, 12 KB)

To reproduce this:

  • Enable Spaces.
  • View the edit form of an object with a mutable view policy (like a task, normally).
  • Narrow your screen.

Related Objects

Event Timeline

epriestley created this task.

A similar issue occurs when the "Visible To" control wraps with spaces enabled. To reproduce this...

These reproduction instructions are insufficient. The normal edit form is actually fine, it's only when the edit form appears in a dialog, ala HarbormasterAdd Build StepAdd New Credential.

Fixing this completely correctly in the general case is a little tricky and probably requires adding a new set of wrapper divs that are definitely not a table.

For now, I'm tweaking margins a little to get mostly-better behavior.