Page MenuHomePhabricator

Index Herald fields, not just actions, when identifying objects related to a particular Herald rule
ClosedPublic

Authored by epriestley on Mon, Sep 9, 7:44 PM.

Details

Summary

Fixes T13408. Currently, when a package (or other object) appears in a field (rather than an action), it is not indexed.

Instead: index fields too, not just actions.

Test Plan
  • Wrote a rule like "[ Affected packages include ] ...".
  • Updated the search index.
  • Saw rule appear on "Affected By Herald Rules" on the package detail page.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Mon, Sep 9, 7:44 PM
Owners added a subscriber: Restricted Owners Package.Mon, Sep 9, 7:44 PM
epriestley requested review of this revision.Mon, Sep 9, 7:45 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mon, Sep 9, 7:50 PM
This revision was automatically updated to reflect the committed changes.