Page MenuHomePhabricator
Differential D20795

Index Herald fields, not just actions, when identifying objects related to a particular Herald rule
ClosedPublic
Actions

Authored by epriestley on Sep 9 2019, 7:44 PM.
Tags
None
Referenced Files
F18388745: D20795.id.diff
Fri, Aug 29, 5:02 AM
F18384112: D20795.id.diff
Thu, Aug 28, 11:47 PM
F18352565: D20795.id49584.diff
Tue, Aug 26, 11:35 PM
F18104696: D20795.id.diff
Sun, Aug 10, 1:38 PM
F18100691: D20795.diff
Sat, Aug 9, 12:00 PM
F18091565: D20795.id.diff
Wed, Aug 6, 10:38 PM
F18084670: D20795.diff
Tue, Aug 5, 4:39 PM
F17712038: D20795.diff
Jul 17 2025, 9:22 AM
View All Files
Subscribers
Restricted Owners Package

Details

Reviewers
None
Maniphest Tasks
T13408: Examine conditions, not just actions, when indexing Herald rules for links to other objects
Commits
rPd965d9a669b5: Index Herald fields, not just actions, when identifying objects related to a…
Summary

Fixes T13408. Currently, when a package (or other object) appears in a field (rather than an action), it is not indexed.

Instead: index fields too, not just actions.

Test Plan
  • Wrote a rule like "[ Affected packages include ] ...".
  • Updated the search index.
  • Saw rule appear on "Affected By Herald Rules" on the package detail page.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Sep 9 2019, 7:44 PM
Owners added a subscriber: Restricted Owners Package.Sep 9 2019, 7:44 PM
Harbormaster completed remote builds in B23409: Diff 49584.Sep 9 2019, 7:45 PM
epriestley requested review of this revision.Sep 9 2019, 7:45 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 9 2019, 7:50 PM
Closed by commit rPd965d9a669b5: Index Herald fields, not just actions, when identifying objects related to a… (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rPd965d9a669b5: Index Herald fields, not just actions, when identifying objects related to a….

Revision Contents
Changeset List

PathSize
resources/
sql/
autopatches/
3 lines
src/
applications/
herald/
engineextension/
14 lines
field/
22 lines

Diff 49586

View Options

resources/sql/autopatches/20190909.herald.01.rebuild.php

Loading...
View Options

src/applications/herald/engineextension/HeraldRuleIndexEngineExtension.php

Loading...
View Options

src/applications/herald/field/HeraldField.php

Loading...
Phabricator · Built by Phacility