Page MenuHomePhabricator

Index Herald fields, not just actions, when identifying objects related to a particular Herald rule
ClosedPublic

Authored by epriestley on Sep 9 2019, 7:44 PM.
Tags
None
Referenced Files
F19083053: D20795.id49586.diff
Dec 2 2025, 12:29 PM
F18985197: D20795.id49584.diff
Nov 17 2025, 12:55 PM
F18806758: D20795.id.diff
Oct 18 2025, 9:26 PM
F18799515: D20795.diff
Oct 17 2025, 3:28 PM
F18776729: D20795.id49584.diff
Oct 10 2025, 11:10 PM
F18768555: D20795.diff
Oct 8 2025, 4:12 AM
F18767068: D20795.id.diff
Oct 7 2025, 8:28 PM
F18734029: D20795.id.diff
Sep 30 2025, 10:47 PM
Subscribers
Restricted Owners Package

Details

Summary

Fixes T13408. Currently, when a package (or other object) appears in a field (rather than an action), it is not indexed.

Instead: index fields too, not just actions.

Test Plan
  • Wrote a rule like "[ Affected packages include ] ...".
  • Updated the search index.
  • Saw rule appear on "Affected By Herald Rules" on the package detail page.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Sep 9 2019, 7:44 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 9 2019, 7:50 PM
This revision was automatically updated to reflect the committed changes.