Page MenuHomePhabricator

Index Herald fields, not just actions, when identifying objects related to a particular Herald rule
ClosedPublic

Authored by epriestley on Sep 9 2019, 7:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 8, 6:58 PM
Unknown Object (File)
Thu, Dec 5, 8:55 AM
Unknown Object (File)
Fri, Nov 29, 11:09 AM
Unknown Object (File)
Sun, Nov 24, 2:10 PM
Unknown Object (File)
Oct 18 2024, 5:08 AM
Unknown Object (File)
Oct 11 2024, 9:26 AM
Unknown Object (File)
Oct 11 2024, 4:19 AM
Unknown Object (File)
Oct 2 2024, 2:34 AM
Subscribers
Restricted Owners Package

Details

Summary

Fixes T13408. Currently, when a package (or other object) appears in a field (rather than an action), it is not indexed.

Instead: index fields too, not just actions.

Test Plan
  • Wrote a rule like "[ Affected packages include ] ...".
  • Updated the search index.
  • Saw rule appear on "Affected By Herald Rules" on the package detail page.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Sep 9 2019, 7:44 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 9 2019, 7:50 PM
This revision was automatically updated to reflect the committed changes.