Page MenuHomePhabricator

Index Herald fields, not just actions, when identifying objects related to a particular Herald rule
ClosedPublic

Authored by epriestley on Sep 9 2019, 7:44 PM.
Tags
None
Referenced Files
F19718287: D20795.id49586.diff
Thu, Feb 12, 3:21 PM
F19675696: D20795.diff
Sun, Feb 8, 10:36 AM
F19509428: D20795.diff
Jan 10 2026, 7:42 PM
F19502587: D20795.diff
Jan 8 2026, 5:23 PM
F19502574: D20795.diff
Jan 8 2026, 5:15 PM
F19502573: D20795.diff
Jan 8 2026, 5:15 PM
F19502543: D20795.diff
Jan 8 2026, 5:04 PM
F19083053: D20795.id49586.diff
Dec 2 2025, 12:29 PM
Subscribers
Restricted Owners Package

Details

Summary

Fixes T13408. Currently, when a package (or other object) appears in a field (rather than an action), it is not indexed.

Instead: index fields too, not just actions.

Test Plan
  • Wrote a rule like "[ Affected packages include ] ...".
  • Updated the search index.
  • Saw rule appear on "Affected By Herald Rules" on the package detail page.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Sep 9 2019, 7:44 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 9 2019, 7:50 PM
This revision was automatically updated to reflect the committed changes.