Page MenuHomePhabricator

"Land Revision" builds a commit message as an omnipotent user, not the revision author or landing user
Open, LowPublic


See rP433a7321ff2585aec3ebbb23f59c0392f7e34e7e. This commit has this as part of the message:

Subscribers: Korvin, O14 ATC Monitoring

This is technically a policy violation because neither @jlinahan (the revision author) nor I (the landing user) can see package O14. Revisions I land with arc report this package as:

Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam

DrydockLandRepositoryOperation should build the commit message as the user clicking the button, not the omnipotent user. Probably, $viewer should be the button-clicker for the entire operation scope.

This issue is extremely minor, but the current behavior is not correct.