Paths

Table of Contentst

Differential D18104

Give "x committed <commit>" feed stories an explicitly higher action strength than other transactions
ClosedPublic
Actions

Authored by epriestley on Jun 8 2017, 12:45 PM.

Tags

None

Referenced Files

	F18146774: D18104.id43561.diff
	Thu, Aug 14, 4:11 PM

	F18110903: D18104.id43551.diff
	Tue, Aug 12, 1:37 AM

	F17948853: D18104.id.diff
	Thu, Jul 31, 10:07 PM

	F17930241: D18104.diff
	Wed, Jul 30, 5:48 PM

	F17902653: D18104.id43561.diff
	Tue, Jul 29, 10:20 AM

	Unknown Object (File)
	Jun 2 2025, 10:59 AM

	Unknown Object (File)
	May 30 2025, 7:33 PM

	Unknown Object (File)
	May 29 2025, 4:00 PM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T12811: For commits, "committed" transaction is no longer stronger than other transactions like auditors and projects via Herald

Commits

rPe26cd3ffe0f9: Give "x committed <commit>" feed stories an explicitly higher action strength…

Summary

Fixes T12811. The issue here appears to be that both the "alice committed rXYZabc" and "Herald added projects..." actions have the same (default) strength and end up applying in arbitrary order, and probably got shuffled around as this transitioned to Modular transactions.

Give "alice committed rXYZabc" an explicitly higher action strength.

Test Plan

Wrote an "Always, add project X" Herald rule for commits.
Ran bin/repository reparse --herald ....
Saw an "alice committed rXYZabc" story instead of a "Herald added projects: X" story.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jun 8 2017, 12:45 PM

Harbormaster completed remote builds in B17448: Diff 43551.Jun 8 2017, 12:45 PM

Harbormaster completed remote builds in B17448: Diff 43551.

epriestley mentioned this in T12811: For commits, "committed" transaction is no longer stronger than other transactions like auditors and projects via Herald.Jun 8 2017, 1:27 PM

chad accepted this revision.Jun 8 2017, 10:06 PM

This revision is now accepted and ready to land.Jun 8 2017, 10:06 PM

Closed by commit rPe26cd3ffe0f9: Give "x committed <commit>" feed stories an explicitly higher action strength… (authored by epriestley, committed by epriestley). · Explain WhyJun 8 2017, 10:25 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

audit/

storage/

PhabricatorAuditTransaction.php

11 lines

Diff 43561

src/applications/audit/storage/PhabricatorAuditTransaction.php

Loading...