Page MenuHomePhabricator

Consider a "Check All" control for reviewer checkbox lists
Open, NormalPublic

Description

An install reports that they have hundreds of millions of packages which are required reviewers on every change, and engineers must work non-stop in rotating shifts to check off all the checkboxes so that any changes may move forward.

We could perhaps provide a "Check All Boxes" button to the control to help with this.

Event Timeline

lvital added a subscriber: lvital.May 25 2017, 7:22 PM

FWIW, a check-all box is what we had in mind.

Another solution I could imagine is to add a distinct action, other than "Accept", which works like the old "Accept" did, i.e. "Accept for all reviewers I have authority to accept for", say "Accept Magnanimously".

I'm hesitant to pursue this today because I want to be cautious about adding too many actions, and I think other changes may add more valuable actions ("Accept Next Update", draft-state actions from T2543, etc). This action would probably be fine today in isolation since the dropdown doesn't feel too cluttered right now, but if we added it I think it might be the least valuable / least frequently used action in a list that is starting to look pretty bloated six months from now.

(I think it's also somewhat hard to pick a 2-3 word phrase which clearly describes how this potential action differs from "Accept" -- I can't come up with anything good offhand.)

epriestley moved this task from Backlog to Nits on the Customer Impact board.May 25 2017, 9:19 PM

Another solution I could imagine is to add a distinct action, other than "Accept", which works like the old "Accept" did, i.e. "Accept for all reviewers I have authority to accept for", say "Accept Magnanimously".

I'm hesitant to pursue this today because I want to be cautious about adding too many actions, and I think other changes may add more valuable actions ("Accept Next Update", draft-state actions from T2543, etc). This action would probably be fine today in isolation since the dropdown doesn't feel too cluttered right now, but if we added it I think it might be the least valuable / least frequently used action in a list that is starting to look pretty bloated six months from now.

(I think it's also somewhat hard to pick a 2-3 word phrase which clearly describes how this potential action differs from "Accept" -- I can't come up with anything good offhand.)

Yeah, a distinct action might be a little overkill and probably not worth cluttering the action list. It's probably an action you'd want to discourage anyway.

Another approach might be to do T11934 first, and then implement this as /accept-magnainmously. This would be very hard to discover, but it's possible that ~10 users worldwide are meaningfully impacted and I could send them each a nice fruit basket with a card explaining the feature.

That could work too. Perhaps a box of donuts instead though.