Page MenuHomePhabricator

Make JX.Tooltip more conservative about positioning

Authored by epriestley on Jan 5 2017, 4:52 PM.



Fixes T10687. Fixes T12064.

  • Primarily, adds a margin around the edge of the screen for the purposes of aligning the tooltip.
  • Also, tries to flip the tooltip if it can (e.g., if the tooltip normally goes east, try west first), then tries other positions exhastively.
Test Plan

Screen Shot 2017-01-05 at 8.48.28 AM.png (207×226 px, 8 KB)

Screen Shot 2017-01-05 at 8.49.17 AM.png (266×318 px, 15 KB)

Diff Detail

rP Phabricator
Lint Not Applicable
Tests Not Applicable

Event Timeline

chad edited edge metadata.

8071526975_7bc933b835.jpg (375×500 px, 69 KB)

Curiously, this did not transition to "Accepted".

This revision is now accepted and ready to land.Jan 5 2017, 5:05 PM

I think "Accept" + "Comment" may be interacting, probably not too tricky to fix.

This revision was automatically updated to reflect the committed changes.