Page MenuHomePhabricator

In the "Version Information" panel, try to include branchpoints
ClosedPublic

Authored by epriestley on Dec 23 2016, 4:34 PM.
Tags
None
Referenced Files
F12830449: D17103.diff
Thu, Mar 28, 12:12 PM
Unknown Object (File)
Tue, Mar 26, 7:36 PM
Unknown Object (File)
Sun, Mar 24, 6:21 AM
Unknown Object (File)
Mon, Mar 18, 6:45 PM
Unknown Object (File)
Jan 22 2024, 12:21 AM
Unknown Object (File)
Dec 24 2023, 5:58 PM
Unknown Object (File)
Dec 9 2023, 7:24 PM
Unknown Object (File)
Dec 4 2023, 2:58 PM
Subscribers
None

Details

Summary

Fixes T12040. In T12039, a user running local patches followed the report instructions as far as grabbing version information, but didn't update or revert their local changes or try against a clean install before reporting.

This obviously isn't ideal for us, but it's understandable (grabbing version information is much easier than upgrading/reverting), and we can do better about making this information useful: when compiling version information, try to figure out the branchpoint from a known upstream master branch by listing remotes, then running git merge-base against them.

Additionally, explicitly document that we want upstream hashes. We have to have a fallback case in this document anyway (for when you can't get to Config) so hopefully this makes it more likely that we get useful information in initial reports.

Test Plan

Screen Shot 2016-12-23 at 8.24.44 AM.png (765×1 px, 218 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable