Differential D16601

When summing points on a workboard, display sum with same precision as most-precise value
ClosedPublic
Actions

Authored by epriestley on Sep 27 2016, 4:31 PM.

Details

Reviewers

chad

Maniphest Tasks

T11703: Floating point issue on points on workboards

Commits

rPf2bb9bc06143: When summing points on a workboard, display sum with same precision as most…

Summary

Fixes T11703. This mostly avoids rounding errors.

If point values include "0.001", we also get three digits of precision: 1.000.

Maybe useful if your point field is called "bitcoins" or something.

Test Plan

Before:

Screen Shot 2016-09-27 at 9.21.16 AM.png (404×319 px, 19 KB)

After:

Screen Shot 2016-09-27 at 9.29.05 AM.png (497×968 px, 51 KB)

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 39964.Sep 27 2016, 4:31 PM

epriestley retitled this revision from to When summing points on a workboard, display sum with same precision as most-precise value.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11703: Floating point issue on points on workboards.

epriestley mentioned this in T11703: Floating point issue on points on workboards.Sep 27 2016, 4:32 PM

chad accepted this revision.Sep 27 2016, 4:36 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Sep 27 2016, 4:36 PM

Closed by commit rPf2bb9bc06143: When summing points on a workboard, display sum with same precision as most… (authored by epriestley, committed by epriestley). · Explain WhySep 27 2016, 4:36 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

12 lines

webroot/

rsrc/

js/

application/

projects/

WorkboardColumn.js

11 lines

Diff 39965

View Options

resources/celerity/map.php