Page MenuHomePhabricator

Fix ContainsConstraints for array-valued custom field constraints in "*.search" methods
ClosedPublic

Authored by epriestley on Sep 7 2016, 2:38 PM.
Tags
None
Referenced Files
F18851968: D16508.diff
Fri, Oct 31, 5:44 AM
F18830140: D16508.id.diff
Sat, Oct 25, 4:25 AM
F18630601: D16508.id.diff
Sep 16 2025, 12:08 PM
F18627080: D16508.id.diff
Sep 16 2025, 3:08 AM
F18622015: D16508.diff
Sep 15 2025, 10:11 AM
F18620862: D16508.diff
Sep 15 2025, 6:28 AM
F18588199: D16508.diff
Sep 11 2025, 11:33 PM
F18508051: D16508.id.diff
Sep 5 2025, 2:35 AM
Subscribers
None

Details

Summary

Fixes T11593. We ask for a list of values when searching for custom "link" fields, but don't handle it correctly when actually construcitng a query.

Test Plan

Added this custom field:

{
  "mycompany.target-version": {
    "name": "Target Version",
    "type": "link",
    "search": true
  }
}

Set a task to "beta". Let daemons index it. Queried for:

constraints: {
  "custom.mycompany.target-version": [
    "beta"
  ]
}

Got just one result back.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix ContainsConstraints for array-valued custom field constraints in "*.search" methods.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 7 2016, 3:57 PM
This revision was automatically updated to reflect the committed changes.