Page MenuHomePhabricator

Fix ContainsConstraints for array-valued custom field constraints in "*.search" methods
ClosedPublic

Authored by epriestley on Sep 7 2016, 2:38 PM.
Tags
None
Referenced Files
F14055645: D16508.id39727.diff
Sat, Nov 16, 2:11 PM
F13987103: D16508.id39727.diff
Mon, Oct 21, 7:30 AM
F13981122: D16508.id39734.diff
Oct 19 2024, 2:22 PM
F13974103: D16508.id39727.diff
Oct 18 2024, 4:06 AM
F13967708: D16508.id.diff
Oct 16 2024, 3:24 PM
F13961446: D16508.diff
Oct 15 2024, 5:09 AM
Unknown Object (File)
Oct 9 2024, 8:26 PM
Unknown Object (File)
Oct 4 2024, 11:35 AM
Subscribers
None

Details

Summary

Fixes T11593. We ask for a list of values when searching for custom "link" fields, but don't handle it correctly when actually construcitng a query.

Test Plan

Added this custom field:

{
  "mycompany.target-version": {
    "name": "Target Version",
    "type": "link",
    "search": true
  }
}

Set a task to "beta". Let daemons index it. Queried for:

constraints: {
  "custom.mycompany.target-version": [
    "beta"
  ]
}

Got just one result back.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix ContainsConstraints for array-valued custom field constraints in "*.search" methods.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 7 2016, 3:57 PM
This revision was automatically updated to reflect the committed changes.