Page MenuHomePhabricator
Create Task
Maniphest T11225

Paste snippets show up double spaced in the context of an audit
Closed, ResolvedPublic
Actions

Description

phabricator e984f0eb76fea6e6777706e9f16105208d112f43 (Fri, Jun 24)
arcanist 2374403e8f80a8fb16cdc1ce2843f932632e8cf0 (Fri, Jun 17)
phutil 5796beffff1653f312256c2788f02e37ffaa5126 (Mon, Jun 27)

  1. Create a paste (I verified with plain text and Swift source)
  2. Try to inline it in an Audit comment with {P###}
  3. Notice that the inlined snippet shows up doublespaced.

Revisions and Commits

rP Phabricator
D16184rP84ce86311658 Select <td> padding for inlines more surgically

Related Objects

Event Timeline

anton.vladimirov created this task.Jun 28 2016, 6:33 PM
chad added a project: Paste.Jun 28 2016, 7:06 PM
epriestley added a subscriber: epriestley.Jun 28 2016, 9:01 PM

This reproduces for me:

Screen Shot 2016-06-28 at 1.55.00 PM.png (566×841 px, 83 KB)

Several CSS rules are bleeding in, but the big culprit appears to be this one:

Screen Shot 2016-06-28 at 1.56.12 PM.png (114×321 px, 15 KB)

Since this is only intended to apply to the containing <td />, I think this is an easy fix.

epriestley added a revision: D16184: Select <td> padding for inlines more surgically.Jun 28 2016, 9:04 PM
epriestley closed this task as Resolved by committing rP84ce86311658: Select <td> padding for inlines more surgically.Jun 28 2016, 9:50 PM
epriestley added a commit: rP84ce86311658: Select <td> padding for inlines more surgically.
epriestley added a comment.Jun 28 2016, 10:02 PM

Thanks for the report, and for including detailed reproduction steps. This should be fixed in HEAD of master, and will promote to stable at the end of the week. Let us know if you run into anything else.

anton.vladimirov added a comment.Jun 28 2016, 10:03 PM

Thanks for fixing it so quickly!

Phabricator · Built by Phacility