Page MenuHomePhabricator

Select <td> padding for inlines more surgically
ClosedPublic

Authored by epriestley on Jun 28 2016, 9:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 9, 10:44 PM
Unknown Object (File)
Feb 22 2024, 10:56 PM
Unknown Object (File)
Feb 22 2024, 10:54 PM
Unknown Object (File)
Feb 14 2024, 8:32 PM
Unknown Object (File)
Feb 14 2024, 8:13 PM
Unknown Object (File)
Feb 8 2024, 8:48 AM
Unknown Object (File)
Feb 5 2024, 3:39 PM
Unknown Object (File)
Jan 18 2024, 10:53 PM
Subscribers
None

Details

Summary

Fixes T11225. The primary issue here is that this rule is bleeding down too far. It appears that it's only intended to put space around the inline as a whole.

Spacing still isn't perfect since a few other rules are bleeding, but it feels reasonable now instead of being clearly broken.

Test Plan
  • Added "background: red;" to figure out what was being affected.
  • Before:

Screen Shot 2016-06-28 at 1.55.00 PM.png (566×841 px, 83 KB)

  • After:

Screen Shot 2016-06-28 at 2.01.04 PM.png (451×754 px, 50 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Select <td> padding for inlines more surgically.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 28 2016, 9:10 PM
This revision was automatically updated to reflect the committed changes.