Put the keyboard focus reticle back on top of diffs
ClosedPublic
Actions

Authored by epriestley on Apr 24 2017, 10:21 AM.

Details

Reviewers

chad

Maniphest Tasks

T10954: Differential keyboard shortcut inline selection reticle is visually unclear (bad z-index?)

Commits

rP27bdc322fc11: Put the keyboard focus reticle back on top of diffs

Summary

Fixes T10954. This got hidden underneath things at some point.

Use pointer-events: none to make the mouse ignore the element so that hover/select/edit/click still work "through" the element.

Design could probably be improved here, maybe I'll make it more-visible when you press n and then have it fade quickly so it kind of gets out of your way once you find the block you want to read.

Test Plan

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 24 2017, 10:21 AM

Harbormaster completed remote builds in B16688: Diff 42761.Apr 24 2017, 10:22 AM

chad accepted this revision.Apr 24 2017, 5:12 PM

This revision is now accepted and ready to land.Apr 24 2017, 5:12 PM

Closed by commit rP27bdc322fc11: Put the keyboard focus reticle back on top of diffs (authored by epriestley, committed by epriestley). · Explain WhyApr 24 2017, 5:24 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

webroot/

rsrc/

css/

application/

base/

standard-page-view.css

5 lines

core/

z-index.css

8 lines

Diff 42764

View Options

webroot/rsrc/css/application/base/standard-page-view.css