Page MenuHomePhabricator

Put the keyboard focus reticle back on top of diffs
ClosedPublic

Authored by epriestley on Apr 24 2017, 10:21 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 2, 1:49 PM
Unknown Object (File)
Thu, Sep 29, 6:00 AM
Unknown Object (File)
Sun, Sep 25, 2:56 AM
Unknown Object (File)
Fri, Sep 23, 9:41 PM
Unknown Object (File)
Wed, Sep 21, 8:02 PM
Unknown Object (File)
Tue, Sep 20, 11:41 PM
Unknown Object (File)
Sun, Sep 18, 9:35 PM
Unknown Object (File)
Fri, Sep 16, 8:12 PM
Subscribers
None

Details

Summary

Fixes T10954. This got hidden underneath things at some point.

Use pointer-events: none to make the mouse ignore the element so that hover/select/edit/click still work "through" the element.

Design could probably be improved here, maybe I'll make it more-visible when you press n and then have it fade quickly so it kind of gets out of your way once you find the block you want to read.

Test Plan

Screen Shot 2017-04-24 at 3.16.35 AM.png (259×1 px, 28 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Apr 24 2017, 5:12 PM
This revision was automatically updated to reflect the committed changes.