Page MenuHomePhabricator
Differential D15830

New icons, colors for per reviewer status
ClosedPublic
Actions

Authored by chad on May 1 2016, 7:35 PM.
Tags
None
Referenced Files
F13086867: D15830.diff
Thu, Apr 25, 12:45 AM
Unknown Object (File)
Thu, Apr 11, 8:34 AM
Unknown Object (File)
Sun, Apr 7, 5:37 PM
Unknown Object (File)
Mon, Apr 1, 9:55 PM
Unknown Object (File)
Mon, Apr 1, 9:02 PM
Unknown Object (File)
Mon, Apr 1, 8:22 PM
Unknown Object (File)
Fri, Mar 29, 10:25 AM
Unknown Object (File)
Wed, Mar 27, 7:33 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T10820: Missing left padding in "Auditors" field on Diffusion Commit
T10906: Differential StatusView icons for "rejected" vs "rejected older" are differentiated only by color
Commits
rP562d427f097e: New icons, colors for per reviewer status
Summary

Fixes T10906, Fixes T10820. Adds new icons, grey-er colors for previous states. Also, I think fixed a few bugs?

Test Plan

Fake each state, verify icon is as intended.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 38133.May 1 2016, 7:35 PM
chad retitled this revision from to New icons, colors for per reviewer status.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T10906: Differential StatusView icons for "rejected" vs "rejected older" are differentiated only by color.
Herald added a subscriber: Korvin. · View Herald TranscriptMay 1 2016, 7:35 PM
chad updated this revision to Diff 38134.May 1 2016, 7:50 PM
  • Clean up PHUIStatusList UI
epriestley accepted this revision.May 1 2016, 7:50 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 1 2016, 7:50 PM
epriestley mentioned this in D15826: Don't communicate action on older diffs exclusively through the use of color/tooltips.May 1 2016, 7:51 PM
chad added a comment.May 1 2016, 7:51 PM

pasted_file (120×222 px, 11 KB)

chad updated this object.May 1 2016, 7:52 PM
chad edited edge metadata.
chad added a task: T10820: Missing left padding in "Auditors" field on Diffusion Commit.
Closed by commit rP562d427f097e: New icons, colors for per reviewer status (authored by chad, committed by chad). · Explain WhyMay 1 2016, 7:52 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
applications/
differential/
view/
19 lines
webroot/
rsrc/
css/
phui/
13 lines

Diff 38135

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/differential/view/DifferentialReviewersView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-status.css

Loading...
Phabricator · Built by Phacility