more generally: arc land from detached state fails in a silly way while still succeeding to ship code
steps
- arc land --hold
- run tests or whatever
- arc land
expect
arc being smart enough to realize the state it's left the repo in and just complete the ship without incident
actual
arc does the git push to origin but crashes on attempting to delete the current "branch"
Cleaning up branch "e1fc513258d063541c333b237dd78f77679460c1"... (Use `git checkout -b e1fc513258d063541c333b237dd78f77679460c1 e1fc513258d063541c333b237dd78f77679460c1` if you want it back.) Exception Command failed with error #1! COMMAND git branch -D -- 'e1fc513258d063541c333b237dd78f77679460c1' STDOUT (empty) STDERR error: branch 'e1fc513258d063541c333b237dd78f77679460c1' not found.
if arc could detect it's not on an actual branch and just skip the deletion step, I believe everything else would work just fine
FAQ
Q: but...
A: yes, I know this isn't the workflow arc land --hold suggests. people aren't good at reading suggested workflows.