Page MenuHomePhabricator
Differential D15458

When replying to a ghost comment, attach the reply to the same place
ClosedPublic
Actions

Authored by epriestley on Mar 11 2016, 12:08 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 13, 2:07 AM
Unknown Object (File)
Thu, Dec 12, 10:33 PM
Unknown Object (File)
Tue, Dec 10, 1:18 PM
Unknown Object (File)
Wed, Dec 4, 6:24 AM
Unknown Object (File)
Sat, Nov 30, 3:31 AM
Unknown Object (File)
Thu, Nov 28, 10:59 PM
Unknown Object (File)
Thu, Nov 28, 10:58 PM
Unknown Object (File)
Thu, Nov 28, 10:58 PM
View All Files
Subscribers
eadler

Details

Reviewers
chad
Maniphest Tasks
T10562: Inline comments can become separated if replies cross update boundaries
Commits
Restricted Diffusion Commit
rP8858b6cf8d17: When replying to a ghost comment, attach the reply to the same place
Summary

Fixes T10562. I left this behavior sort of ambiguous in the original implementation because I didn't anticipate or stumble across this situation.

It's easy to fix: when you reply to a ghost, just put the reply in the exact same place as the ghost (even if it's a different diff), so they always move/ghost/port/thread together.

Test Plan

See T10562 for reproduction steps and a "before" picture. Here's the after picture:

Screen Shot 2016-03-10 at 4.04.52 PM.png (922×924 px, 93 KB)

The two comments at the bottom are pre-fix, and exhibit the bug. The comment at the top is post-fix, and appears adjacent to the original correctly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 37253.Mar 11 2016, 12:08 AM
epriestley retitled this revision from to When replying to a ghost comment, attach the reply to the same place.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10562: Inline comments can become separated if replies cross update boundaries.
Herald edited edge metadata. · View Herald TranscriptMar 11 2016, 12:08 AM
epriestley mentioned this in T10562: Inline comments can become separated if replies cross update boundaries.Mar 11 2016, 12:09 AM
chad accepted this revision.Mar 11 2016, 12:13 AM
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 11 2016, 12:13 AM
eadler added a subscriber: eadler.Mar 11 2016, 12:22 AM
Closed by commit rP8858b6cf8d17: When replying to a ghost comment, attach the reply to the same place (authored by epriestley, committed by epriestley). · Explain WhyMar 11 2016, 12:41 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
infrastructure/
diff/
17 lines

Diff 37255

View Options

src/infrastructure/diff/PhabricatorInlineCommentController.php

Loading...
Phabricator · Built by Phacility