Page MenuHomePhabricator

When replying to a ghost comment, attach the reply to the same place
ClosedPublic

Authored by epriestley on Mar 11 2016, 12:08 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 27, 1:32 PM
Unknown Object (File)
Mon, May 26, 8:19 PM
Unknown Object (File)
Fri, May 2, 6:10 AM
Unknown Object (File)
Apr 30 2025, 12:25 AM
Unknown Object (File)
Apr 26 2025, 12:24 AM
Unknown Object (File)
Apr 22 2025, 9:54 PM
Unknown Object (File)
Apr 21 2025, 12:34 PM
Unknown Object (File)
Apr 20 2025, 8:05 PM
Subscribers

Details

Summary

Fixes T10562. I left this behavior sort of ambiguous in the original implementation because I didn't anticipate or stumble across this situation.

It's easy to fix: when you reply to a ghost, just put the reply in the exact same place as the ghost (even if it's a different diff), so they always move/ghost/port/thread together.

Test Plan

See T10562 for reproduction steps and a "before" picture. Here's the after picture:

Screen Shot 2016-03-10 at 4.04.52 PM.png (922×924 px, 93 KB)

The two comments at the bottom are pre-fix, and exhibit the bug. The comment at the top is post-fix, and appears adjacent to the original correctly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to When replying to a ghost comment, attach the reply to the same place.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 11 2016, 12:13 AM
This revision was automatically updated to reflect the committed changes.