Page MenuHomePhabricator

Fix some visibility issues with inline comments in Diffusion
ClosedPublic

Authored by epriestley on Mar 5 2016, 9:55 PM.
Tags
None
Referenced Files
F14013293: D15407.id37145.diff
Sat, Nov 2, 4:00 AM
F14013274: D15407.id37146.diff
Sat, Nov 2, 3:22 AM
F14013134: D15407.id.diff
Sat, Nov 2, 1:27 AM
F14011942: D15407.diff
Fri, Nov 1, 6:12 AM
F13988898: D15407.id.diff
Mon, Oct 21, 4:35 PM
F13968658: D15407.diff
Oct 16 2024, 10:34 PM
F13955951: D15407.id37145.diff
Oct 14 2024, 3:41 AM
Unknown Object (File)
Sep 14 2024, 9:09 AM
Subscribers
None

Details

Summary

Fixes T10519. Two issues:

First, the acting user wasn't explicitly included in the mail. This usually didn't matter, but could matter if you unsubscribed and then interacted.

Second, we had some logic which tried to hide redundant "added inline comment" transactions, but could hide them inappropriately. In particular, if another action (like a subscribe) was present in the same group, we could hide the inlines because of that other transaction, then also hide the subscribe. This particular issue is likely an unintended consequence of hiding self-subscribes.

Instead of hiding inlines if anything else happened, hide them only if:

  • there is another "added a comment" transaction; or
  • there is another "added an inline comment" transaction.

This prevents the root issue in T10519 (incorrectly hiding every transaction, and thus not sending the mail) and should generally make behavior a little more consistent and future-proof.

Test Plan
  • Submitted only an inline comment on a commit I had not previously interacted with.
  • Before patch: no mail was generated (entire mail was improperly hidden).
  • After patch: got some mail with my comment.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix some visibility issues with inline comments in Diffusion.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 5 2016, 10:08 PM
This revision was automatically updated to reflect the committed changes.