Page MenuHomePhabricator

Fix weird remarkup linewrapping on a few instructions forms, plus move toward fixing Phame/CORGI remarkup issues
ClosedPublic

Authored by epriestley on May 22 2016, 4:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 25, 7:00 PM
Unknown Object (File)
Mon, Mar 25, 6:36 PM
Unknown Object (File)
Mon, Mar 25, 6:15 PM
Unknown Object (File)
Mon, Mar 25, 5:36 PM
Unknown Object (File)
Mon, Mar 25, 3:47 PM
Unknown Object (File)
Sat, Mar 23, 12:26 PM
Unknown Object (File)
Sat, Mar 23, 10:40 AM
Unknown Object (File)
Thu, Mar 21, 1:15 PM
Subscribers
None

Details

Summary

Fixes T10381. When we converted to PHUIRemarkupView, some instructional text got linebreaks added when it shouldn't have them (the source is written in PHP and wrapped at 80 characters, but the output should flow naturally).

Fix this so we don't preserve linebreaks.

This also makes PHUIRemarkupView a little more powerful and inches us toward fixing Phame/CORGI remarkup issues, getting rid of PhabricatorMarkupInterface / PhabricatorMarkupOneOff, and dropping all the application hard-coding in PhabricatorMarkupEngine.

Test Plan
  • Grepped for all callsites, looking for callsites which accept remarkup written in <<<HEREDOC format.
  • Viewed form instructions, Conduit API methods, HTTP parameter edit instructions.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix weird remarkup linewrapping on a few instructions forms, plus move toward fixing Phame/CORGI remarkup issues.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
src/infrastructure/markup/view/PHUIRemarkupView.php
52–58

This stuff doesn't actually have any callers, so I just stripped it out.

chad edited edge metadata.
This revision is now accepted and ready to land.May 22 2016, 6:38 PM
This revision was automatically updated to reflect the committed changes.