Page MenuHomePhabricator

Process Configuration For Code Reviews
Closed, ResolvedPublic

Asked by MurrayIrvine on Sep 21 2015, 3:26 PM.

Details

Hi there,

I have been googling and have looked through lots of the usual Phabricator documentation about setting up email, and doing diffs etc but I just can't find the answer to my questions.

I am trying to setup the following:

  1. Developer commits new code in Mercurial.
  2. Developer types in "arc diff".....to create a new diff.
  3. I would like to auto fill in the code review specifics by asking all attached members on the project / repository to do a review.
  4. I would like to automatically send an email to all the attached members of the project / repository to say that a code review needs to be done.

I have linked Notepad++ as the default editor.
I have gone through the settings for "Mail - Configure Mail" in the Phabricator homepage.
I still haven't figured out how to setup the actual mail SMTP settings for "PHPMailer - Configure PHPMailer" in the Phabricator homepage because it says that they are locked.

How do I bypass the need for the developer to edit a text file in Notepad++, fill in details, save the file and close Notepad++ before the diff is created?
How do I attach the auto email events to a project / repository to send out emails when new diffs are created?

Thanks in advance!

Answers

cspeckmim
Updated 3,110 Days Ago

How do I bypass the need for the developer to edit a text file in Notepad++, fill in details, save the file and close Notepad++ before the diff is created?

I think the recommended way to resolve this is by using Projects. For my team of developers I have a project #team_r which are the group of reviewers and #team_s which is essentially everyone else on team who can subscribe.

When a developer fills out the text file (which is required) it looks like this:

Task ##### - Short title of changes

Summary:
 - Itemized list of changes
 - 

Test Plan:
Description of how the change will be tested

Reviewers:
#team_r

Subscribers:
#team_s

They can also add additional developers not on the team who would be familiar with the changes as well, giving input.

How do I attach the auto email events to a project / repository to send out emails when new diffs are created?

If you have the Mail application configured properly, the above process will email all the reviewers and subscribers. Most all the options are listed at /config/group/metamta/.

I still haven't figured out how to setup the actual mail SMTP settings for "PHPMailer - Configure PHPMailer" in the Phabricator homepage because it says that they are locked.

If you look at the config option, even though it says it's locked, it will tell you more information:

This configuration is locked and can not be edited from the web interface. Use ./bin/config in phabricator/ to edit it.

You can only modify the setting from the command line while ssh'd into the server.

New Answer

Answer

This question has been marked as closed, but you can still leave a new answer.