Page MenuHomePhabricator

Rename `PhabricatorDestructableInterface` interface
ClosedPublic

Authored by joshuaspence on Jul 20 2014, 10:04 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 15, 2:57 AM
Unknown Object (File)
Fri, Dec 13, 9:55 PM
Unknown Object (File)
Fri, Dec 13, 10:35 AM
Unknown Object (File)
Tue, Dec 3, 5:14 AM
Unknown Object (File)
Tue, Nov 26, 8:05 PM
Unknown Object (File)
Fri, Nov 22, 5:17 PM
Unknown Object (File)
Nov 18 2024, 4:25 AM
Unknown Object (File)
Nov 18 2024, 1:00 AM
Subscribers

Details

Summary

Ref T5655. The PhabricatorDestructibleInterface interface is misspelled as PhabricatorDestructableInterface. Fix the spelling mistake.

Test Plan

grep. Seeing as this interface is fairly recent, I don't expect that this would cause any widespread breakages.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence retitled this revision from to Rename `PhabricatorDestructableInterface` interface.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence edited edge metadata.
src/applications/system/interface/PhabricatorDestructableInterface.php
11–24

I got rid of this because I don't think it is necessary now that there are a bunch of classes which implement the interface.

epriestley edited edge metadata.
epriestley added inline comments.
src/applications/system/interface/PhabricatorDestructableInterface.php
11–24

Consider retaining this for consistency -- it's trivial here, but I find it pretty useful for some of the slightly more involved interfaces, like PhabricatorPolicyInterface and PhabricatorApplicationTransactionInterface. It also prevents the copy/paste error where you miss one copy of the application/object you copied from (e.g., I copy from "paste" and miss renaming one instance of "paste") and then get valid code that doesn't work, since it guarantees the code is invalid until all of the blanks are filled in.

This revision is now accepted and ready to land.Jul 21 2014, 1:29 PM
joshuaspence edited edge metadata.
  • Leave "TEMPLATE IMPLEMENTATION" comments
joshuaspence updated this revision to Diff 24027.

Closed by commit rP76ed7d1a02c9 (authored by @joshuaspence).