Ref T5655. The PhabricatorDestructibleInterface interface is misspelled as PhabricatorDestructableInterface. Fix the spelling mistake.
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T5655: Standardize naming conventions
- Commits
- Restricted Diffusion Commit
rP76ed7d1a02c9: Rename `PhabricatorDestructableInterface` interface
grep. Seeing as this interface is fairly recent, I don't expect that this would cause any widespread breakages.
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
src/applications/system/interface/PhabricatorDestructableInterface.php | ||
---|---|---|
11–24 | I got rid of this because I don't think it is necessary now that there are a bunch of classes which implement the interface. |
src/applications/system/interface/PhabricatorDestructableInterface.php | ||
---|---|---|
11–24 | Consider retaining this for consistency -- it's trivial here, but I find it pretty useful for some of the slightly more involved interfaces, like PhabricatorPolicyInterface and PhabricatorApplicationTransactionInterface. It also prevents the copy/paste error where you miss one copy of the application/object you copied from (e.g., I copy from "paste" and miss renaming one instance of "paste") and then get valid code that doesn't work, since it guarantees the code is invalid until all of the blanks are filled in. |